Skip to contentSkip to conversation

dts: synquacer: Drop unused and undocumented SPI properties

PATCH In review Rob Herring 5 participants 10 messages Dec 9, 2022 – Jan 3, 2023 Arm (32-bit)

lore
Share & tools
lore
#1 lore raw

PATCH 2/2 dts: synquacer: Drop unused and undocumented GPIO 'base' property

In reply to Rob Herring

The 'base' GPIO controller property is unused in u-boot and Linux. It is also not documented in the binding. So drop it.

---
 arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/synquacer-sc2a11.dtsi +0 -1
index 0dd2969b5e3c..7ba1cd1bee70 100644
@@ -497,7 +497,6 @@
         gpio-controller;
         #gpio-cells = <2>;
         clocks = <&clk_apb>;
-        base = <0>;
     };
 
     exiu: interrupt-controller@510c0000 {
Signature · 1 line
2.35.1
#0 lore raw

PATCH 1/2 dts: synquacer: Drop unused and undocumented SPI properties

'active_clk_edges' and 'chipselect_num' SPI controller properties are unused in u-boot and Linux. They are also not documented in the binding. So drop them.

---
 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -2
index 6b85c05458d4..9f9837b33bef 100644
@@ -20,8 +20,6 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
-		active_clk_edges;
-		chipselect_num = <1>;
 
 		flash@0 {
 			#address-cells = <1>;
Signature · 1 line
2.35.1
Reviewed-by on v1 1/2
#6 lore raw

+ Jassi

Quoted 15 lines · Rob Herring

'active_clk_edges' and 'chipselect_num' SPI controller properties are unused in u-boot and Linux. They are also not documented in the binding. So drop them.

---
 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -0
index 6b85c05458d4..9f9837b33bef 100644

arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi line 24

Quoted 5 lines
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -2
@@ -20,8 +20,6 @@
                #address-cells = <1>;
                #size-cells = <0>;
                status = "okay";
-               active_clk_edges;
-               chipselect_num = <1>;

Thank you for cleaning up the unused properties.

Regards,
Masahisa Kojima

Quoted 6 lines
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -1
                flash@0 {
                        #address-cells = <1>;
--

2.35.1

Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

In reply to Rob Herring

+ Jassi

Quoted 14 lines · Rob Herring

The 'base' GPIO controller property is unused in u-boot and Linux. It is also not documented in the binding. So drop it.

---
 arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/synquacer-sc2a11.dtsi +0 -0
index 0dd2969b5e3c..7ba1cd1bee70 100644

arch/arm/dts/synquacer-sc2a11.dtsi line 500

Quoted 4 lines
arch/arm/dts/synquacer-sc2a11.dtsi +0 -1
@@ -497,7 +497,6 @@
         gpio-controller;
         #gpio-cells = <2>;
         clocks = <&clk_apb>;
-        base = <0>;

Regards,
Masahisa Kojima

Quoted 6 lines
arch/arm/dts/synquacer-sc2a11.dtsi +0 -1
     };
 
     exiu: interrupt-controller@510c0000 {
--

2.35.1

Acked-by on v1 1/2
#8 lore raw
In reply to Rob Herring
Quoted 25 lines · Rob Herring

'active_clk_edges' and 'chipselect_num' SPI controller properties are unused in u-boot and Linux. They are also not documented in the binding. So drop them.

---
 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -2
index 6b85c05458d4..9f9837b33bef 100644
@@ -20,8 +20,6 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
-		active_clk_edges;
-		chipselect_num = <1>;
 
 		flash@0 {
 			#address-cells = <1>;
Signature · 1 line
2.35.1
Acked-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

In reply to Rob Herring
Quoted 23 lines · Rob Herring

The 'base' GPIO controller property is unused in u-boot and Linux. It is also not documented in the binding. So drop it.

---
 arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/synquacer-sc2a11.dtsi +0 -1
index 0dd2969b5e3c..7ba1cd1bee70 100644
@@ -497,7 +497,6 @@
         gpio-controller;
         #gpio-cells = <2>;
         clocks = <&clk_apb>;
-        base = <0>;
     };
 
     exiu: interrupt-controller@510c0000 {
Signature · 1 line
2.35.1
Acked-by
#7 lore raw
In reply to Masahisa Kojima
Quoted 14 lines · Masahisa Kojima

+ Jassi

Quoted 10 lines · Rob Herring

'active_clk_edges' and 'chipselect_num' SPI controller properties are unused in u-boot and Linux. They are also not documented in the binding. So drop them.

---
 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)
Quoted 13 lines

arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi line 24

Quoted 10 lines
arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +0 -2
index 6b85c05458d4..9f9837b33bef 100644
@@ -20,8 +20,6 @@
                #address-cells = <1>;
                #size-cells = <0>;
                status = "okay";
-               active_clk_edges;
-               chipselect_num = <1>;
Acked-by
#3 lore raw

Re: [PATCH 2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

In reply to Masahisa Kojima
Quoted 13 lines · Masahisa Kojima

+ Jassi

Quoted 9 lines · Rob Herring

The 'base' GPIO controller property is unused in u-boot and Linux. It is also not documented in the binding. So drop it.

---
 arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
 1 file changed, 1 deletion(-)
Quoted 12 lines

arch/arm/dts/synquacer-sc2a11.dtsi line 500

Quoted 9 lines
arch/arm/dts/synquacer-sc2a11.dtsi +0 -1
index 0dd2969b5e3c..7ba1cd1bee70 100644
@@ -497,7 +497,6 @@
         gpio-controller;
         #gpio-cells = <2>;
         clocks = <&clk_apb>;
-        base = <0>;
#5 lore raw

Re: [PATCH 2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

In reply to Rob Herring
Quoted 7 lines · Rob Herring

The 'base' GPIO controller property is unused in u-boot and Linux. It is also not documented in the binding. So drop it.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom