Skip to contentSkip to conversation

test: env: add test for u-boot-initial-env creation

PATCH In review Max Krummenacher 3 participants 3 messages Dec 9, 2022 – Jan 12, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: env: add test for u-boot-initial-env creation

From: Max Krummenacher <[email protected]>

Checks that make u-boot-initial-env creates the text file u-boot-initial-env and checks that it at least contains board=<something>.

---

Changes in v1:
I assume every board has a board environment variable but I don't test its value. I.e. the test succseeds even if a board sets it to some arbitrary string at build time.
-
Tested only with 'sandbox'.
-
As proposed by Simon, see
https://lore.kernel.org/all/CAPnjgZ0V_Fdj9EvzD1hOYa7VqeptsueAuPj5ktYa7owO1qr_CQ@mail.gmail.com/
Thanks for the pointers tn where to add and where to look for a host test example. This was very helpful.

 test/py/tests/test_env.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
test/py/tests/test_env.py +23 -0
index 6d08565f0b5..ea1e4c76e09 100644
@@ -8,6 +8,7 @@ Test operation of shell commands relating to environment variables.
 
 import os
 import os.path
+import re
 from subprocess import call, CalledProcessError
 import tempfile
 
@@ -173,6 +174,28 @@ def validate_set(state_test_env, var, value):
     response = state_test_env.u_boot_console.run_command('printenv %s' % var)
     assert response == ('%s=%s' % (var, value))
 
+def test_env_initial_env_file(u_boot_console):
+    """Test that the u-boot-initial-env make target works"""
+    cons = u_boot_console
+    builddir = 'O=' + cons.config.build_dir
+    envfile = cons.config.build_dir + '/u-boot-initial-env'
+
+    # remove if already exists from an older run
+    try:
+        os.remove(envfile)
+    except:
+        pass
+
+    u_boot_utils.run_and_log(cons, ['make', builddir, 'u-boot-initial-env'])
+
+    assert os.path.exists(envfile)
+
+    # assume that every environment has a board variable, e.g. board=sandbox
+    with open(envfile, 'r') as file:
+        env = file.read()
+    regex = re.compile('board=.+\\n')
+    assert re.search(regex, env)
+
 def test_env_echo_exists(state_test_env):
     """Test echoing a variable that exists."""
 
Signature · 1 line
2.35.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Max Krummenacher

From: Max Krummenacher <[email protected]>

Checks that make u-boot-initial-env creates the text file u-boot-initial-env and checks that it at least contains board=<something>.

---

Changes in v1:
I assume every board has a board environment variable but I don't test its value. I.e. the test succseeds even if a board sets it to some arbitrary string at build time.
-
Tested only with 'sandbox'.
-
As proposed by Simon, see
https://lore.kernel.org/all/CAPnjgZ0V_Fdj9EvzD1hOYa7VqeptsueAuPj5ktYa7owO1qr_CQ@mail.gmail.com/
Thanks for the pointers tn where to add and where to look for a host test example. This was very helpful.

Quoted 3 lines
 test/py/tests/test_env.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Nice