Skip to contentSkip to conversation

kselftests-cgroup-update-kmem-test-precision-tolerance.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Dec 10, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: kselftests: cgroup: update kmem test precision tolerance
has been removed from the -mm tree. Its filename was
kselftests-cgroup-update-kmem-test-precision-tolerance.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Michal Hocko <[email protected]>
Subject: kselftests: cgroup: update kmem test precision tolerance
Date: Fri, 2 Dec 2022 09:50:26 +0100

1813e51eece0 ("memcg: increase MEMCG_CHARGE_BATCH to 64") has changed the batch size while this test case has been left behind. This has led to a test failure reported by test bot:
not ok 2 selftests: cgroup: test_kmem # exit=1

Update the tolerance for the pcp charges to reflect the MEMCG_CHARGE_BATCH change to fix this.

[[email protected]: update comments, per Roman]
Fixes 1813e51eece0a ("memcg: increase MEMCG_CHARGE_BATCH to 64")
Cc Eric Dumazet <[email protected]>
Cc Feng Tang <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc "Michal Koutný" <[email protected]>
Cc Muchun Song <[email protected]>
Cc Soheil Hassas Yeganeh <[email protected]>

---

 tools/testing/selftests/cgroup/test_kmem.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/cgroup/test_kmem.c renamed from tools/testing/selftests/cgroup/test_kmem.c~kselftests-cgroup-update-kmem-test-precision-tolerance +3 -3
@@ -19,12 +19,12 @@
 
 
 /*
- * Memory cgroup charging is performed using percpu batches 32 pages
+ * Memory cgroup charging is performed using percpu batches 64 pages
  * big (look at MEMCG_CHARGE_BATCH), whereas memory.stat is exact. So
  * the maximum discrepancy between charge and vmstat entries is number
- * of cpus multiplied by 32 pages.
+ * of cpus multiplied by 64 pages.
  */
-#define MAX_VMSTAT_ERROR (4096 * 32 * get_nprocs())
+#define MAX_VMSTAT_ERROR (4096 * 64 * get_nprocs())
 
 
 static int alloc_dcache(const char *cgroup, void *arg)

_

Patches currently in -mm which might be from [email protected] are