serial: Do not write additional \r before \n for dm_serial drivers
PATCH 1/1 serial: Do not write additional \r before \n for dm_serial drivers
serial-uclass.c code already puts \r before \n for all dm_serial drivers.
Signed-off-by Pali Rohár <[email protected]>
--- drivers/serial/serial_lpuart.c | 3 --- drivers/serial/serial_mpc8xx.c | 3 --- 2 files changed, 6 deletions(-)
drivers/serial/serial_lpuart.c +0 -3
@@ -349,9 +349,6 @@ static void _lpuart32_serial_putc(struct lpuart_serial_plat *plat,struct lpuart_fsl_reg32 *base = plat->reg;u32 stat; -if (c =='\n' ) -serial_putc ('\r' ); -while (true) {lpuart_read32 (plat->flags, &base->stat, &stat);
drivers/serial/serial_mpc8xx.c +0 -3
@@ -176,9 +176,6 @@ static int serial_mpc8xx_putc(struct udevice *dev, const char c)cpm8xx_t __iomem *cpmp = &(im->im_cpm);struct serialbuffer __iomem *rtx; -if (c =='\n' ) -serial_mpc8xx_putc (dev,'\r' ); - rtx = (struct serialbuffer __iomem *)&cpmp->cp_dpmem[CPM_SERIAL_BASE ];/* Wait for last character to go. */
Signature · 1 line
2.20.1
Quoted 3 lines · Pali Rohár
serial-uclass.ccode already puts \r before \n for alldm_serialdrivers.Signed-off-by Pali Rohár <[email protected]>
Reviewed-by Stefan Roese <[email protected]>
Thanks,
Stefan
Quoted 24 lines
--- drivers/serial/serial_lpuart.c | 3 --- drivers/serial/serial_mpc8xx.c | 3 --- 2 files changed, 6 deletions(-)drivers/serial/serial_lpuart.c +0
-3@@ -349,9 +349,6 @@ static void _lpuart32_serial_putc(struct lpuart_serial_plat *plat,struct lpuart_fsl_reg32 *base = plat->reg;u32 stat; -if (c =='\n' ) -serial_putc ('\r' ); -while (true) {lpuart_read32 (plat->flags, &base->stat, &stat);drivers/serial/serial_mpc8xx.c +0
-0
drivers/serial/serial_mpc8xx.c static int serial_mpc8xx_putc(struct udevice *dev, const char c) · line 181
Quoted 9 lines
drivers/serial/serial_mpc8xx.c +0
-3@@ -176,9 +176,6 @@ static int serial_mpc8xx_putc(struct udevice *dev, const char c)cpm8xx_t __iomem *cpmp = &(im->im_cpm);struct serialbuffer __iomem *rtx; -if (c =='\n' ) -serial_mpc8xx_putc (dev,'\r' ); - rtx = (struct serialbuffer __iomem *)&cpmp->cp_dpmem[CPM_SERIAL_BASE ];/* Wait for last character to go. */
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 9 lines · Pali Rohár
serial-uclass.ccode already puts \r before \n for alldm_serialdrivers.Signed-off-by Pali Rohár <[email protected]>--- drivers/serial/serial_lpuart.c | 3 --- drivers/serial/serial_mpc8xx.c | 3 --- 2 files changed, 6 deletions(-)
Reviewed-by Simon Glass <[email protected]>
Quoted 5 lines · Pali Rohár
serial-uclass.ccode already puts \r before \n for alldm_serialdrivers.Signed-off-by Pali Rohár <[email protected]>Reviewed-by Stefan Roese <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/next, thanks!
Signature · 1 line
Tom