Skip to contentSkip to conversation

tests/kms_color: Gamma tests should require hw support

PATCH In review Rob Clark 3 participants 3 messages Dec 11, 2022 – Dec 12, 2022

lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 tests/kms_color: Gamma tests should require hw support

From: Rob Clark <[email protected]>

Some qcom devices support CTM but not gamma/degamma LUT.

Note, the remaining failures on msm are due to CTM being supported on one CRTC but not the other. But the property is exposed on both.

---
 tests/kms_color.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_color.c +2 -0
index d016cefb..cf9c27fe 100644
@@ -230,6 +230,8 @@ static bool test_pipe_legacy_gamma(data_t *data,
 	legacy_lut_size = kms_crtc->gamma_size;
 	drmModeFreeCrtc(kms_crtc);
 
+	igt_require(legacy_lut_size > 0);
+
 	red_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
 	green_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
 	blue_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
Signature · 1 line
2.38.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Gamma tests should require hw support

== Series Details ==

== Series Details ==

Series: tests/kms_color: Gamma tests should require hw support
URL : https://patchwork.freedesktop.org/series/111826/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12491 -> IGTPW_8217
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8217 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8217, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html

Participating hosts (41 -> 39)
------------------------------

Missing (2): bat-rpls-2 bat-atsm-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8217:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-kbl-soraka/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@i915_selftest@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@slpc:
- {bat-adlp-9}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adlp-9/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adlp-9/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8217 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0@smem:
- bat-adlp-4: [PASS][7] -> [DMESG-WARN][8] ([i915#2867])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adlp-4/igt@gem_exec_suspend@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adlp-4/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][9] -> [DMESG-FAIL][10] ([i915#5334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][11] -> [INCOMPLETE][12] ([i915#4785])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-hsw-4770/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][13] -> [INCOMPLETE][14] ([i915#4817])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-rkl-11600/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-rkl-11600/igt@[email protected]

* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#4312] / [i915#5594])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-hsw-4770/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [FAIL][16] ([i915#4312] / [i915#4991])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_pm:
- {bat-adln-1}: [DMESG-FAIL][17] ([i915#4258]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adln-1/igt@i915_selftest@live@gt_pm.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adln-1/igt@i915_selftest@live@gt_pm.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][19] ([i915#6298]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7090 -> IGTPW_8217

CI-20190529: 20190529
CI_DRM_12491: d322881f7e33af24901ee8ccaec3beef82f21203 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8217: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html
IGT_7090: 5aafcf060b6dfbb2fa7aace76c8074d98ac7da8f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

-igt@i915_hwmon@hwmon-read
-igt@i915_hwmon@hwmon-write

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Clark
Quoted 10 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Rob Clark
Sent: Monday, December 12, 2022 1:22 AM
To: [email protected]
Cc: Rob Clark <[email protected]>
Subject: [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support

Quoted 6 lines

From: Rob Clark <[email protected]>

Some qcom devices support CTM but not gamma/degamma LUT.

Note, the remaining failures on msm are due to CTM being supported on one CRTC but not the other. But the property is exposed on both.

Looks good to me.

Quoted 19 lines
---
 tests/kms_color.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_color.c +2 -1
@@ -230,6 +230,8 @@ static bool test_pipe_legacy_gamma(data_t *data,
 	legacy_lut_size = kms_crtc->gamma_size;
 	drmModeFreeCrtc(kms_crtc);
 
+	igt_require(legacy_lut_size > 0);
+
 	red_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
 	green_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
 	blue_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
--

2.38.1