Skip to contentSkip to conversation

mm-fadvise-use-llong_max-instead-of-1-for-eof.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 12, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/fadvise: use LLONG_MAX instead of -1 for eof
has been removed from the -mm tree. Its filename was
mm-fadvise-use-llong_max-instead-of-1-for-eof.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Brian Foster <[email protected]>
Subject: mm/fadvise: use LLONG_MAX instead of -1 for eof
Date: Mon, 28 Nov 2022 10:56:32 -0500

generic_fadvise() sets endbyte = -1 to specify end of file (i.e. if length == 0 is passed from userspace). Most other callers to filemap_fdatawrite_range() use LLONG_MAX for this purpose, particularly if they also call fdatawait_range() (which requires end >= start). For example, sync_file_range(), vfs_fsync() (where the range is passed down through per-fs ->fsync() callbacks), filemap_flush(), etc. generic_fadvise() does not currently wait on writeback, but fix the call up to be consistent with other callers.

---

 mm/fadvise.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/fadvise.c renamed from mm/fadvise.c~mm-fadvise-use-llong_max-instead-of-1-for-eof +1 -1
@@ -72,7 +72,7 @@ int generic_fadvise(struct file *file, l
 	 */
 	endbyte = (u64)offset + (u64)len;
 	if (!len || endbyte < len)
-		endbyte = -1;
+		endbyte = LLONG_MAX;
 	else
 		endbyte--;		/* inclusive */
 

_

Patches currently in -mm which might be from [email protected] are