Skip to contentSkip to conversation

extfat-remove-writepage.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 12, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: extfat: remove ->writepage

has been removed from the -mm tree. Its filename was
extfat-remove-writepage.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Christoph Hellwig <[email protected]>
Subject: extfat: remove ->writepage
Date: Fri, 2 Dec 2022 11:26:38 +0100

Patch series "start removing writepage instances v2".

The VM doesn't need or want ->writepage for writeback and is fine with just having ->writepages as long as ->migrate_folio is implemented.

This series removes all ->writepage instances that use block_write_full_page directly and also have a plain mpage_writepages based ->writepages.

This patch (of 7):

->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation.

---

 fs/exfat/inode.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
fs/exfat/inode.c renamed from fs/exfat/inode.c~extfat-remove-writepage +2 -7
@@ -345,11 +345,6 @@ static void exfat_readahead(struct reada
 	mpage_readahead(rac, exfat_get_block);
 }
 
-static int exfat_writepage(struct page *page, struct writeback_control *wbc)
-{
-	return block_write_full_page(page, exfat_get_block, wbc);
-}
-
 static int exfat_writepages(struct address_space *mapping,
 		struct writeback_control *wbc)
 {
@@ -473,12 +468,12 @@ static const struct address_space_operat
 	.invalidate_folio = block_invalidate_folio,
 	.read_folio	= exfat_read_folio,
 	.readahead	= exfat_readahead,
-	.writepage	= exfat_writepage,
 	.writepages	= exfat_writepages,
 	.write_begin	= exfat_write_begin,
 	.write_end	= exfat_write_end,
 	.direct_IO	= exfat_direct_IO,
-	.bmap		= exfat_aop_bmap
+	.bmap		= exfat_aop_bmap,
+	.migrate_folio	= buffer_migrate_folio,
 };
 
 static inline unsigned long exfat_hash(loff_t i_pos)

_

Patches currently in -mm which might be from [email protected] are