Skip to contentSkip to conversation

omfs-remove-writepage.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 12, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: omfs: remove ->writepage

has been removed from the -mm tree. Its filename was
omfs-remove-writepage.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Christoph Hellwig <[email protected]>
Subject: omfs: remove ->writepage
Date: Fri, 2 Dec 2022 11:26:44 +0100

->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation.

---

 fs/omfs/file.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
fs/omfs/file.c renamed from fs/omfs/file.c~omfs-remove-writepage +1 -6
@@ -294,11 +294,6 @@ static void omfs_readahead(struct readah
 	mpage_readahead(rac, omfs_get_block);
 }
 
-static int omfs_writepage(struct page *page, struct writeback_control *wbc)
-{
-	return block_write_full_page(page, omfs_get_block, wbc);
-}
-
 static int
 omfs_writepages(struct address_space *mapping, struct writeback_control *wbc)
 {
@@ -375,10 +370,10 @@ const struct address_space_operations om
 	.invalidate_folio = block_invalidate_folio,
 	.read_folio = omfs_read_folio,
 	.readahead = omfs_readahead,
-	.writepage = omfs_writepage,
 	.writepages = omfs_writepages,
 	.write_begin = omfs_write_begin,
 	.write_end = generic_write_end,
 	.bmap = omfs_bmap,
+	.migrate_folio = buffer_migrate_folio,
 };
 

_

Patches currently in -mm which might be from [email protected] are