drm/etnaviv: Remove redundant dev_err()
Subsystems (2)
PATCH v2 1/1 drm/etnaviv: Remove redundant dev_err()
Function dev_err() is redundant because platform_get_irq() already prints an error.
Signed-off-by Kang Minchul <[email protected]>
---
Changes in v2:
- Removed unnecessary braces.
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_gpu.c +1 -3
@@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)/* Get Interrupt: */ gpu->irq =platform_get_irq (pdev,0 ); -if (gpu->irq <0 ) { -dev_err (dev,"failed to get irq: %d\n" , gpu->irq); +if (gpu->irq <0 )return gpu->irq; - } err =devm_request_irq (&pdev->dev, gpu->irq, irq_handler,0 ,dev_name (gpu->dev), gpu);
Signature · 1 line
2.34.1
2022년 12월 12일 (월) 오후 3:14, Kang Minchul <[email protected]>님이 작성:
Quoted 29 lines
Function
dev_err()is redundant becauseplatform_get_irq()already prints an error.Signed-off-by Kang Minchul <[email protected]>---
Changes in v2:
- Removed unnecessary braces.drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_gpu.c +1
-4@@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)/* Get Interrupt: */ gpu->irq =platform_get_irq (pdev,0 ); -if (gpu->irq <0 ) { -dev_err (dev,"failed to get irq: %d\n" , gpu->irq); +if (gpu->irq <0 )return gpu->irq; - } err =devm_request_irq (&pdev->dev, gpu->irq, irq_handler,0 ,dev_name (gpu->dev), gpu); --
Quoted 2 lines
2.34.1
I guess problem dealt with by this patch have already been resolved in the past. I think I worked on the wrong branch.
Please ignore this patch.
Sorry for your inconvenience.
Regards,
Kang Minchul