net: Fix memory corruption in eth_halt() if the stop handler frees the priv member
PATCH 1/1 net: Fix memory corruption in eth_halt() if the stop handler frees the priv member
Calling eth_halt() could result in memory corruption if the stop() handler frees or modifies the priv member.
A stored value of dev_get_uclass_priv() is assumed to remain valid after the stop() handler has been called, which is not always the case (e.g. rndis over usb gadget).
Re-check the priv pointer after calling the stop() handler.
--- net/eth-uclass.c | 5 +++++ 1 file changed, 5 insertions(+)
net/eth-uclass.c +5 -0
@@ -343,6 +343,11 @@ void eth_halt(void)return ;eth_get_ops (current)->stop (current); + + priv =dev_get_uclass_priv (current); +if (!priv || !priv->running) +return ; + priv->state =ETH_STATE_PASSIVE ; priv->running = false; }
Signature · 1 line
2.38.1
Hi Bernhard,
Quoted 20 lines · Bernhard Rosenkränzer
Calling
eth_halt()could result in memory corruption if thestop()handler frees or modifies the priv member.A stored value of
dev_get_uclass_priv()is assumed to remain valid after thestop()handler has been called, which is not always the case (e.g. rndis over usb gadget).Re-check the priv pointer after calling the
stop()handler.Signed-off-by Bernhard Rosenkränzer <[email protected]>--- net/eth-uclass.c | 5 +++++ 1 file changed, 5 insertions(+)net/eth-uclass.c +0
-0
net/eth-uclass.c void eth_halt(void) · line 350
Quoted 8 lines
net/eth-uclass.c +5
-0@@ -343,6 +343,11 @@ void eth_halt(void)return ;eth_get_ops (current)->stop (current); + + priv =dev_get_uclass_priv (current); +if (!priv || !priv->running) +return ; +
Niel submitted the same fix:
https://lists.denx.de/pipermail/u-boot/2022-December/502055.html