Skip to contentSkip to conversation

fuse: remove duplicate check for nodeid

PATCH Applied zyfjeff 2 participants 2 messages Dec 13, 2022 – Feb 1, 2023

Subsystems (2)
lore
Share & tools
lore

zyfjeff

author
#0 lore raw

PATCH 1/1 fuse: remove duplicate check for nodeid

before this check, the nodeid has already been checked once, so the check here doesn't make an sense, so remove the check for nodeid here.

            if (err || !outarg->nodeid)
                    goto out_put_forget;

            err = -EIO;
    >>>     if (!outarg->nodeid)
                    goto out_put_forget;
---
 fs/fuse/dir.c | 2 --
 1 file changed, 2 deletions(-)
fs/fuse/dir.c +0 -2
index cd1a071b625a..a33cd1131640 100644
@@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
 		goto out_put_forget;
 
 	err = -EIO;
-	if (!outarg->nodeid)
-		goto out_put_forget;
 	if (fuse_invalid_attr(&outarg->attr))
 		goto out_put_forget;
 
Signature · 1 line
2.34.0
maintainer Applied
#1 lore raw
Quoted 5 lines · zyfjeff

before this check, the nodeid has already been checked once, so the check here doesn't make an sense, so remove the check for nodeid here.

Quoted 8 lines
            if (err || !outarg->nodeid)
                    goto out_put_forget;

            err = -EIO;
    >>>     if (!outarg->nodeid)
                    goto out_put_forget;

Applied, thanks.

Miklos