Skip to contentSkip to conversation

efibootmgr: update compilation with musl

PATCH In review Marta Rybczynska 2 participants 3 messages Dec 14, 2022 – Dec 15, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efibootmgr: update compilation with musl

Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d (efivar: add musl libc compatibility) efibootmgr compiles with musl too. Update the variable to take that into account.

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -2
index 11d8b9061d..be6571b3fa 100644
@@ -34,6 +34,4 @@ do_install () {
 }
 
 CLEANBROKEN = "1"
-# https://github.com/rhboot/efivar/issues/202
-COMPATIBLE_HOST:libc-musl = 'null'
 
Signature · 1 line
2.35.1
#1 lore raw
Quoted 15 lines · Marta Rybczynska

Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d (efivar: add musl libc compatibility) efibootmgr compiles with musl too. Update the variable to take that into account.

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -0
index 11d8b9061d..be6571b3fa 100644

meta/recipes-bsp/efibootmgr/efibootmgr_17.bb do_install () { · line 38

Quoted 5 lines
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -2
@@ -34,6 +34,4 @@ do_install () {
 }
 
 CLEANBROKEN = "1"
-# https://github.com/rhboot/efivar/issues/202
-COMPATIBLE_HOST:libc-musl = 'null'

I see that master also has the above -- should it also be removed in master? If so, resubmit for master and I will backport to kirkstone.

Thanks!

Steve

Quoted 8 lines
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -1
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#174555): https://lists.openembedded.org/g/openembedded-core/message/174555
Mute This Topic: https://lists.openembedded.org/mt/95667399/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 20 lines · Steve Sakoman

Review

Quoted 11 lines · Marta Rybczynska

Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d (efivar: add musl libc compatibility) efibootmgr compiles with musl too. Update the variable to take that into account.

---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
 1 file changed, 2 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb

Quoted 6 lines

index 11d8b9061d..be6571b3fa 100644

meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -0
@@ -34,6 +34,4 @@ do_install () {
 }
 
Quoted 9 lines

meta/recipes-bsp/efibootmgr/efibootmgr_17.bb do_install () { · line 38

Quoted 3 lines
meta/recipes-bsp/efibootmgr/efibootmgr_17.bb +0 -2
 CLEANBROKEN = "1"
-# https://github.com/rhboot/efivar/issues/202
-COMPATIBLE_HOST:libc-musl = 'null'

I see that master also has the above -- should it also be removed in master? If so, resubmit for master and I will backport to kirkstone.

Al three branches finished compilation just fine, so all three are submitted. You can pick it up the moment
it hits master.

Kind regards,
Marta