Skip to contentSkip to conversation

reset: ti-sci: fix compile test dependencies

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 15, 2022 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: ti-sci: fix compile test dependencies

From: Arnd Bergmann <[email protected]>

The SCI reset driver can be compile testing on targets that do not support the SCI firmware, but it fails to link when the firmware driver is built as a module, and the reset driver is built-in:

arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'

Prevent this configuration by limiting the compile test to configurations without SCI firmware.

Fixes a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +1 -1
index de176c2fbad9..2a52c990d4fe 100644
@@ -257,7 +257,7 @@ config RESET_SUNXI
 
 config RESET_TI_SCI
 	tristate "TI System Control Interface (TI-SCI) reset driver"
-	depends on TI_SCI_PROTOCOL || COMPILE_TEST
+	depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
 	help
 	  This enables the reset driver support over TI System Control Interface
 	  available on some new TI's SoCs. If you wish to use reset resources
Signature · 1 line
2.35.1
#1 lore raw
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The SCI reset driver can be compile testing on targets that do not support the SCI firmware, but it fails to link when the firmware driver is built as a module, and the reset driver is built-in:

Quoted 8 lines

arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'

Prevent this configuration by limiting the compile test to configurations without SCI firmware.

Fixes a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")

https://lore.kernel.org/lkml/[email protected]/

Quoted 17 lines
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +1 -1
index de176c2fbad9..2a52c990d4fe 100644
@@ -257,7 +257,7 @@ config RESET_SUNXI
 
 config RESET_TI_SCI
 	tristate "TI System Control Interface (TI-SCI) reset driver"
-	depends on TI_SCI_PROTOCOL || COMPILE_TEST
+	depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
 	help
 	  This enables the reset driver support over TI System Control Interface
 	  available on some new TI's SoCs. If you wish to use reset resources
Signature · 1 line
~Randy