Skip to contentSkip to conversation

irqchip: armada: suppress unused-function warning

PATCH New Arnd Bergmann 1 participant 1 message Dec 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip: armada: suppress unused-function warning

From: Arnd Bergmann <[email protected]>

armada_370_xp_msi_reenable_percpu is only defined when CONFIG_PCI_MSI is enabled, and only called when SMP is enabled.

Without CONFIG_SMP, there are no callers, so we get a build time warning instead:

drivers/irqchip/irq-armada-370-xp.c:319:13: error: 'armada_370_xp_msi_reenable_percpu' defined but not used [-Werror=unused-function]
319 | static void armada_370_xp_msi_reenable_percpu(void) {}

      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Mark the function as __maybe_unused to avoid adding more complexity to the #ifdefs.

Fixes 8ca61cde32c1 ("irqchip/armada-370-xp: Enable MSI affinity configuration")
---
 drivers/irqchip/irq-armada-370-xp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-armada-370-xp.c +1 -1
index ee18eb3e72b7..178ff63f8e93 100644
@@ -316,7 +316,7 @@ static int armada_370_xp_msi_init(struct device_node *node,
 	return 0;
 }
 #else
-static void armada_370_xp_msi_reenable_percpu(void) {}
+static __maybe_unused void armada_370_xp_msi_reenable_percpu(void) {}
 
 static inline int armada_370_xp_msi_init(struct device_node *node,
 					 phys_addr_t main_int_phys_base)
Signature · 1 line
2.35.1