Bluetooth: Fix issue with Actions Semi ATS2851 based devices
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Fix issue with Actions Semi ATS2851 based devices
Their devices claim to support the erroneous data reporting, but don't actually support the required commands. So blacklist them and add a quirk.
< HCI Command: Read Default Erroneous Data Reporting (0x03|0x005a) plen 0
Quoted 1 line
HCI Event: Command Status (
0x0f) plen 4
Read Default Erroneous Data Reporting (0x03|0x005a) ncmd 1
Status: Unknown HCI Command (0x01)T: Bus=02 Lev=02 Prnt=08 Port=02 Cnt=01 Dev#= 10 Spd=12 MxCh= 0 D: Ver= 2.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=10d7 ProdID=b012 Rev=88.91 S: Manufacturer=Actions S: Product=general adapter S: SerialNumber=ACTIONS1234 C:* #Ifs= 2 Cfg#= 1 Atr=c0 MxPwr=100mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=01(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
--- drivers/bluetooth/btusb.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/bluetooth/btusb.c +9 -0
@@ -64,6 +64,7 @@ static struct usb_driver btusb_driver;#define BTUSB_INTEL_BROKEN_SHUTDOWN_LED BIT(24)#define BTUSB_INTEL_BROKEN_INITIAL_NCMD BIT(25)#define BTUSB_INTEL_NO_WBS_SUPPORT BIT(26) +#define BTUSB_ACTIONS_SEMI BIT(27)static const struct usb_device_id btusb_table[] = {/* Generic Bluetooth USB device */
@@ -677,6 +678,9 @@ static const struct usb_device_id blacklist_table[] = { { USB_DEVICE(0x0cb5, 0xc547), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + /* Actions Semiconductor ATS2851 based devices */ + { USB_DEVICE(0x10d7, 0xb012), .driver_info = BTUSB_ACTIONS_SEMI }, + /* Silicon Wave based devices */ { USB_DEVICE(0x0c10, 0x0000), .driver_info = BTUSB_SWAVE },
@@ -4098,6 +4102,11 @@ static int btusb_probe(struct usb_interface *intf,set_bit (BTUSB_USE_ALT3_FOR_WBS , &data->flags); } +if (id->driver_info &BTUSB_ACTIONS_SEMI ) { +/* Support is advertised, but not implemented */ +set_bit (HCI_QUIRK_BROKEN_ERR_DATA_REPORTING , &hdev->quirks); + } +if (!reset)set_bit (HCI_QUIRK_RESET_ON_CLOSE , &hdev->quirks);
Signature · 1 line
2.38.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=705205
---Test result---
Test Summary:
CheckPatch PASS 0.85 seconds GitLint PASS 0.29 seconds SubjectPrefix PASS 0.10 seconds BuildKernel PASS 32.85 seconds CheckAllWarning PASS 36.24 seconds CheckSparse PASS 41.65 seconds BuildKernel32 PASS 32.38 seconds TestRunnerSetup PASS 461.30 seconds TestRunner_l2cap-tester PASS 17.08 seconds TestRunner_iso-tester PASS 17.46 seconds TestRunner_bnep-tester PASS 5.89 seconds TestRunner_mgmt-tester PASS 112.86 seconds TestRunner_rfcomm-tester PASS 9.38 seconds TestRunner_sco-tester PASS 8.49 seconds TestRunner_ioctl-tester PASS 9.92 seconds TestRunner_mesh-tester PASS 7.46 seconds TestRunner_smp-tester PASS 8.51 seconds TestRunner_userchan-tester PASS 6.18 seconds IncrementalBuild PASS 30.57 seconds
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 10 lines · On Fri, 16 Dec 2022 21:12:47 +0100 you wrote:
Their devices claim to support the erroneous data reporting, but don't actually support the required commands. So blacklist them and add a quirk.
< HCI Command: Read Default Erroneous Data Reporting (0x03|0x005a) plen 0
Quoted 1 line
HCI Event: Command Status (
0x0f) plen 4Read Default Erroneous Data Reporting (0x03|0x005a) ncmd 1 Status: Unknown HCI Command (0x01)[...]
Here is the summary with links:
- Bluetooth: Fix issue with Actions Semi ATS2851 based devices
https://git.kernel.org/bluetooth/bluetooth-next/c/0bb039f39058
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 3 lines · Marcel Holtmann
Their devices claim to support the erroneous data reporting, but don't actually support the required commands. So blacklist them and add a quirk.
This device appears to not support HCI_OP_LE_READ_TRANSMIT_POWER, either. I get this with the above patch applied:
Quoted 1 line
Bluetooth: hci0: Opcode
0x204bfailed: -56
Then it fails to register as a functioning interface, and bluez thinks bluetooth is turned off.
In my case, it's a Techkey long range adapter, which is probably a similar model to the above mentioned Ugreen device, except that it also has a detachable pole antenna.
So sorry for the noise, I didn't notice there was a new patch revision.