Skip to contentSkip to conversation

libvhost-user: Cast rc variable to avoid compiler warning

PATCH In review Marcel Holtmann 1 participant 1 message Dec 19, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 3/7 libvhost-user: Cast rc variable to avoid compiler warning

The assert from recvmsg() return value against an uint32_t size field from a protocol struct throws a compiler warning.

CC libvhost-user.o
In file included from libvhost-user.c:27:
libvhost-user.c: In function ‘vu_message_read_default’:
libvhost-user.c:363:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
363 | assert(rc == vmsg->size);
| ^~

This is not critical, but annoying when the libvhost-user source are used in an external project that has this compiler warning switched on.

---
 subprojects/libvhost-user/libvhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
subprojects/libvhost-user/libvhost-user.c +1 -1
index 67d75ece53b7..bcdf32a24f60 100644
@@ -339,7 +339,7 @@ vu_message_read_default(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
             goto fail;
         }
 
-        assert(rc == vmsg->size);
+        assert((uint32_t)rc == vmsg->size);
     }
 
     return true;
Signature · 1 line
2.38.1