libvhost-user: Use unsigned int i for some for-loop iterations
PATCH 4/7 libvhost-user: Use unsigned int i for some for-loop iterations
The sign-compare warning also hits some of the for-loops, but it easy fixed by just making the iterator variable unsigned int.
CC libvhost-user.olibvhost-user.c: In function ‘vu_gpa_to_va’:
libvhost-user.c:223:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
223 | for (i = 0; i < dev->nregions; i++) {
| ^
Signed-off-by Marcel Holtmann <[email protected]>
--- subprojects/libvhost-user/libvhost-user.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
subprojects/libvhost-user/libvhost-user.c +7 -7
@@ -192,7 +192,7 @@ vu_panic(VuDev *dev, const char *msg, ...)void *vu_gpa_to_va (VuDev *dev,uint64_t *plen,uint64_t guest_addr) { -int i; +unsigned int i;if (*plen ==0 ) {return NULL ;
@@ -218,7 +218,7 @@ vu_gpa_to_va(VuDev *dev, uint64_t *plen, uint64_t guest_addr)static void *qva_to_va (VuDev *dev,uint64_t qemu_addr) { -int i; +unsigned int i;/* Find matching memory region. */ for (i =0 ; i < dev->nregions; i++) {
@@ -621,7 +621,7 @@ map_ring(VuDev *dev, VuVirtq *vq)static bool generate_faults (VuDev *dev) { -int i; +unsigned int i;for (i =0 ; i < dev->nregions; i++) {VuDevRegion *dev_region = &dev->regions[i];int ret;
@@ -829,7 +829,7 @@ static inline bool reg_equal(VuDevRegion *vudev_reg,static bool vu_rem_mem_reg (VuDev *dev,VhostUserMsg *vmsg) {VhostUserMemoryRegion m = vmsg->payload.memreg.region, *msg_region = &m; -int i; +unsigned int i;bool found = false;if (vmsg->fd_num >1 ) {
@@ -895,7 +895,7 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {static bool vu_set_mem_table_exec_postcopy (VuDev *dev,VhostUserMsg *vmsg) { -int i; +unsigned int i;VhostUserMemory m = vmsg->payload.memory, *memory = &m; dev->nregions = memory->nregions;
@@ -972,7 +972,7 @@ vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)static bool vu_set_mem_table_exec (VuDev *dev,VhostUserMsg *vmsg) { -int i; +unsigned int i;VhostUserMemory m = vmsg->payload.memory, *memory = &m;for (i =0 ; i < dev->nregions; i++) {
@@ -1980,7 +1980,7 @@ end:void vu_deinit (VuDev *dev) { -int i; +unsigned int i;for (i =0 ; i < dev->nregions; i++) {VuDevRegion *r = &dev->regions[i];
Signature · 1 line
2.38.1