set_mempolicy01: cancel the limit of maximum runtime
PATCH 1/1 set_mempolicy01: cancel the limit of maximum runtime
It needs more time for running on multiple numa nodes system. Here propose to cancel the limit of max_runtime.
========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16
Summary:
passed 393210 failed 0 broken 0 skipped 0
warnings 0
real 6m15.147s
user 0m33.641s
sys 0m44.553s
--- testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c | 1 + 1 file changed, 1 insertion(+)
testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c +1 -0
@@ -110,6 +110,7 @@ static struct tst_test test = { .tcnt = 2, .forks_child = 1, .needs_checkpoints = 1, + .max_runtime = TST_UNLIMITED_RUNTIME, };#else
Signature · 5 lines
2.38.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 29 lines
It needs more time for running on multiple numa nodes system. Here propose to cancel the limit of
max_runtime.========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16Summary:
passed 393210 failed 0 broken 0 skipped 0
Quoted 5 lines
warnings 0
real 6m15.147s
user 0m33.641s
sys 0m44.553s
Can't we just set the default to 30 minutes or something large enough?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 32 lines · Cyril Hrubis
Hi!
Quoted 31 lines
It needs more time for running on multiple numa nodes system. Here propose to cancel the limit of
max_runtime.========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16Summary:
passed 393210 failed 0 broken 0 skipped 0warnings 0
Quoted 6 lines
Quoted 3 lines
real 6m15.147s
user 0m33.641s
sys 0m44.553sCan't we just set the default to 30 minutes or something large enough?
Yes, I thought about a fixed larger value before, but seems the test time go increased extremely faster when the test matrix doubled.
I don't have a system with more than 32 nodes to check if 30mins enough, so I guess probably canceling the limitation like what we did for oom tests would make sense, that timeout value depends on real system configurations.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hello,
Quoted 41 lines · Li Wang
Quoted 32 lines · Cyril Hrubis
Hi!
Quoted 31 lines
It needs more time for running on multiple numa nodes system. Here propose to cancel the limit of
max_runtime.========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16Summary:
passed 393210 failed 0 broken 0 skipped 0warnings 0
Quoted 6 lines
Quoted 3 lines
real 6m15.147s
user 0m33.641s
sys 0m44.553sCan't we just set the default to 30 minutes or something large enough?
Quoted 7 lines
Yes, I thought about a fixed larger value before, but seems the test time go increased extremely faster when the test matrix doubled.
I don't have a system with more than 32 nodes to check if 30mins enough, so I guess probably canceling the limitation like what we did for oom tests would make sense, that timeout value depends on real system configurations.
IMO, this is what the timeout multiplier is for. So if you have a computer with 512 CPUs or a tiny embedded device, you can adjust the timeouts upwards.
The default timeouts are for workstations, commodity servers and VMs. Although I suppose as this is a NUMA test the average machine will be bigger, but 32 nodes on a physical machine would be 128-512 CPUs?
Quoted 5 lines
Signature · 3 lines
-- Regards, Li Wang
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 48 lines · Richard Palethorpe
Hello,
Quoted 44 lines · Li Wang
Quoted 32 lines · Cyril Hrubis
Hi!
Quoted 31 lines
It needs more time for running on multiple numa nodes system. Here propose to cancel the limit of
max_runtime.========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16Summary:
passed 393210 failed 0 broken 0 skipped 0warnings 0
Quoted 6 lines
Quoted 3 lines
real 6m15.147s
user 0m33.641s
sys 0m44.553sCan't we just set the default to 30 minutes or something large enough?
Yes, I thought about a fixed larger value before, but seems the test time go increased extremely faster when the test matrix doubled.
Quoted 9 lines
Quoted 4 lines
I don't have a system with more than 32 nodes to check if 30mins enough, so I guess probably canceling the limitation like what we did for oom tests would make sense, that timeout value depends on real system configurations.
IMO, this is what the timeout multiplier is for. So if you have a computer with 512 CPUs or a tiny embedded device, you can adjust the timeouts upwards.
Well, exporting LTP_RUNTIME_MUL to a large value is useful for extending the maximal test runtime, but the side effect is, it will change the runtime for many other tests as well, especially those who use tst_remaining_runtime() in their infinite looping (e.g. pty06/7, swapping01, mmap1, fork13),
which leads to the whole LTP suite costing more time to complete.
That's why we love LTP_RUNTIME_MUL but dare not set it too high.
Quoted 5 lines
The default timeouts are for workstations, commodity servers and VMs. Although I suppose as this is a NUMA test the average machine will be bigger, but 32 nodes on a physical machine would be 128-512 CPUs?
I guess yes, after checking one 16nodes physical machine it has 128 CPUs.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/1 set_mempolicy01: adjust the maximum runtime base on nodes
In most cases, set_mempolicy01 finish quickly, but when the platform has multiple NUMA nodes, the test matrix combination grows exponentially and brings about test time to increase extremely fast. Here propose to set the maximum runtime dynamically according to the system nodes.
========= test log on 16 nodes system =========
...
set_mempolicy01.c:80: TPASS: child: Node 15 allocated 16 tst_numa.c:25: TINFO: Node 0 allocated 0 pages tst_numa.c:25: TINFO: Node 1 allocated 0 pages tst_numa.c:25: TINFO: Node 2 allocated 0 pages tst_numa.c:25: TINFO: Node 3 allocated 0 pages tst_numa.c:25: TINFO: Node 4 allocated 0 pages tst_numa.c:25: TINFO: Node 5 allocated 0 pages tst_numa.c:25: TINFO: Node 6 allocated 0 pages tst_numa.c:25: TINFO: Node 7 allocated 0 pages tst_numa.c:25: TINFO: Node 8 allocated 0 pages tst_numa.c:25: TINFO: Node 9 allocated 0 pages tst_numa.c:25: TINFO: Node 10 allocated 0 pages tst_numa.c:25: TINFO: Node 11 allocated 0 pages tst_numa.c:25: TINFO: Node 12 allocated 0 pages tst_numa.c:25: TINFO: Node 13 allocated 0 pages tst_numa.c:25: TINFO: Node 14 allocated 0 pages tst_numa.c:25: TINFO: Node 15 allocated 16 pages set_mempolicy01.c:80: TPASS: parent: Node 15 allocated 16
Summary:
passed 393210 failed 0 broken 0 skipped 0
warnings 0
real 6m15.147s
user 0m33.641s
sys 0m44.553s
--- .../kernel/syscalls/set_mempolicy/set_mempolicy01.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c +10 -0
@@ -35,6 +35,15 @@ static void setup(void) nodes =tst_get_nodemap (TST_NUMA_MEM ,2 *PAGES_ALLOCATED * page_size /1024 );if (nodes->cnt <=1 )tst_brk (TCONF ,"Test requires at least two NUMA memory nodes" ); + +/* +* In most cases, set_mempolicy01 finish quickly, but when the platform +* has multiple NUMA nodes, the test matrix combination grows exponentially +* and bring about test time to increase extremely fast. +* +* Here reset the maximum runtime according to the NUMA nodes. +*/ +tst_set_max_runtime (test.max_runtime * (1 << nodes->cnt/16 )); }static void cleanup (void )
@@ -110,6 +119,7 @@ static struct tst_test test = { .tcnt = 2, .forks_child = 1, .needs_checkpoints = 1, + .max_runtime = 600, };#else
Signature · 5 lines
2.38.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v2] set_mempolicy01: adjust the maximum runtime base on nodes
Hi Li,
LGTM, really better than unlimited time.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v2] set_mempolicy01: adjust the maximum runtime base on nodes
Hello,
Quoted 5 lines · Petr Vorel
Hi Li,
Reviewed-by Petr Vorel <[email protected]>LGTM, really better than unlimited time.
Yes, pushed, thanks!
Quoted 3 lines
Kind regards,
Petr
Signature · 5 lines
Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp