RDMA/erdma: Fix refcount leak in erdma_mmap
Subsystems (2)
PATCH 1/1 RDMA/erdma: Fix refcount leak in erdma_mmap
rdma_user_mmap_entry_get() take reference, we should release it when not need anymore, add the missing rdma_user_mmap_entry_put() in the error path to fix it.
Fixes 155055771704 ("RDMA/erdma: Add verbs implementation")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/infiniband/hw/erdma/erdma_verbs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/infiniband/hw/erdma/erdma_verbs.c +3 -1
@@ -1110,12 +1110,14 @@ int erdma_mmap(struct ib_ucontext *ctx, struct vm_area_struct *vma) prot =pgprot_device (vma->vm_page_prot);break ;default : -return -EINVAL ; + err = -EINVAL ; + goto put_entry; } err =rdma_user_mmap_io (ctx, vma,PFN_DOWN (entry->address),PAGE_SIZE , prot, rdma_entry); +put_entry:rdma_user_mmap_entry_put (rdma_entry);return err; }
Signature · 1 line
2.25.1
Quoted 10 lines · Miaoqian Lin
rdma_user_mmap_entry_get()take reference, we should release it when not need anymore, add the missingrdma_user_mmap_entry_put()in the error path to fix it.Fixes 155055771704 ("RDMA/erdma: Add verbs implementation")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/infiniband/hw/erdma/erdma_verbs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Good catch, thanks.
Acked-by Cheng Xu <[email protected]>
Quoted 20 lines
drivers/infiniband/hw/erdma/erdma_verbs.c +3
-1@@ -1110,12 +1110,14 @@ int erdma_mmap(struct ib_ucontext *ctx, struct vm_area_struct *vma) prot =pgprot_device (vma->vm_page_prot);break ;default : -return -EINVAL ; + err = -EINVAL ; + goto put_entry; } err =rdma_user_mmap_io (ctx, vma,PFN_DOWN (entry->address),PAGE_SIZE , prot, rdma_entry); +put_entry:rdma_user_mmap_entry_put (rdma_entry);return err; }
Leon Romanovsky
AppliedQuoted 5 lines · Miaoqian Lin
rdma_user_mmap_entry_get()take reference, we should release it when not need anymore, add the missingrdma_user_mmap_entry_put()in the error path to fix it.
Applied, thanks!
[1/1] RDMA/erdma: Fix refcount leak in erdma_mmap
https://git.kernel.org/rdma/rdma/c/ee84146c05ad23
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>