Skip to contentSkip to conversation

docs: pmu: fix binding example

PATCH New Conor Dooley 3 participants 3 messages Dec 21, 2022 – Dec 24, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: pmu: fix binding example

From: Conor Dooley <[email protected]>

The first PMU binding example does not terminate properties with a ;, which is invalid. Noticed while converting the binding to yaml.

---
 docs/pmu_support.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
docs/pmu_support.md +3 -3
index 1db36fc..1a16bad 100644
@@ -70,17 +70,17 @@ via platform hooks rather than the device tree.
 ```
 pmu {
 	compatible 			= "riscv,pmu";
-	riscv,event-to-mhpmevent 		= <0x0000B  0x0000 0x0001>,
+	riscv,event-to-mhpmevent 		= <0x0000B  0x0000 0x0001>;
 	riscv,event-to-mhpmcounters 	= <0x00001 0x00001 0x00000001>,
 						  <0x00002 0x00002 0x00000004>,
 						  <0x00003 0x0000A 0x00000ff8>,
-						  <0x10000 0x10033 0x000ff000>,
+						  <0x10000 0x10033 0x000ff000>;
 					/* For event ID 0x0002 */
 	riscv,raw-event-to-mhpmcounters = <0x0000 0x0002 0xffffffff 0xffffffff 0x00000f8>,
 					/* For event ID 0-4 */
 					<0x0 0x0 0xffffffff 0xfffffff0 0x00000ff0>,
 					/* For event ID 0xffffffff0000000f - 0xffffffff000000ff */
-					<0xffffffff 0x0 0xffffffff 0xffffff0f 0x00000ff0>,
+					<0xffffffff 0x0 0xffffffff 0xffffff0f 0x00000ff0>;
 };
 ```
 
Signature · 1 line
2.38.1
Applied
#2 lore raw

PATCH 1/1 docs: pmu: fix binding example

In reply to Conor Dooley
Quoted 7 lines · Conor Dooley

From: Conor Dooley <[email protected]>

The first PMU binding example does not terminate properties with a ;, which is invalid. Noticed while converting the binding to yaml.

Looks good to me.

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

Quoted 37 lines
---
 docs/pmu_support.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
docs/pmu_support.md +3 -4
index 1db36fc..1a16bad 100644
@@ -70,17 +70,17 @@ via platform hooks rather than the device tree.
 ```
 pmu {
        compatible                      = "riscv,pmu";
-       riscv,event-to-mhpmevent                = <0x0000B  0x0000 0x0001>,
+       riscv,event-to-mhpmevent                = <0x0000B  0x0000 0x0001>;
        riscv,event-to-mhpmcounters     = <0x00001 0x00001 0x00000001>,
                                                  <0x00002 0x00002 0x00000004>,
                                                  <0x00003 0x0000A 0x00000ff8>,
-                                                 <0x10000 0x10033 0x000ff000>,
+                                                 <0x10000 0x10033 0x000ff000>;
                                        /* For event ID 0x0002 */
        riscv,raw-event-to-mhpmcounters = <0x0000 0x0002 0xffffffff 0xffffffff 0x00000f8>,
                                        /* For event ID 0-4 */
                                        <0x0 0x0 0xffffffff 0xfffffff0 0x00000ff0>,
                                        /* For event ID 0xffffffff0000000f - 0xffffffff000000ff */
-                                       <0xffffffff 0x0 0xffffffff 0xffffff0f 0x00000ff0>,
+                                       <0xffffffff 0x0 0xffffffff 0xffffff0f 0x00000ff0>;
 };
 ```
 
--

2.38.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi