s390/zcrypt: use strscpy() to instead of strncpy()
Subsystems (2)
PATCH 1/1 s390/zcrypt: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL-terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/s390/crypto/zcrypt_api.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/s390/crypto/zcrypt_api.c +2 -4
@@ -347,8 +347,7 @@ static ssize_t zcdn_create_store(struct class *class,int rc;char name[ZCDN_MAX_NAME ]; -strncpy (name,skip_spaces (buf),sizeof (name)); - name[sizeof (name) -1 ] ='\0' ; +strscpy (name,skip_spaces (buf),sizeof (name)); rc =zcdn_create (strim (name));
@@ -365,8 +364,7 @@ static ssize_t zcdn_destroy_store(struct class *class,int rc;char name[ZCDN_MAX_NAME ]; -strncpy (name,skip_spaces (buf),sizeof (name)); - name[sizeof (name) -1 ] ='\0' ; +strscpy (name,skip_spaces (buf),sizeof (name)); rc =zcdn_destroy (strim (name));
Signature · 1 line
2.15.2
Heiko Carstens
maintainerQuoted 10 lines · On Fri, Dec 23, 2022 at 10:45:21AM +0800, [email protected] wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL-terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>--- drivers/s390/crypto/zcrypt_api.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Please resend and make sure that your Signed-off-by Name+Email address actually matches the From: field of your Email.
Thank you!