Skip to contentSkip to conversation

fstests: report/xunit: report excluded test cases

PATCH New Qu Wenruo 1 participant 1 message Dec 25, 2022 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 fstests: report/xunit: report excluded test cases

When running fstests btrfs runs on my aarch64 VM, test case generic/619 is always a pain, it takes around 100 times the execution time than my x86_64 VMs (100+s on x86_64 vs over 10000+s).

That test case itself would take more time than all the other test cases, thus I have excluded generic/619 for all my aarch64 runs.

But if one test case is excluded, it will only not be recorded in the xmls result at all, making later review harder to expose the problem.

Fix this behavior be also report the expunged cases in xunit.

Now the expunged cases will have the following output, without a message:

	<testcase classname="xfstests.global" name="generic/619" time="0">
		<skipped/>
	</testcase>
---
 check         | 2 +-
 common/report | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
check +1 -1
index 1ff0f44a..c64dce75 100755
@@ -578,7 +578,7 @@ _stash_test_status() {
 	local test_seq="$1"
 	local test_status="$2"
 
-	if $do_report && [[ $test_status != "expunge" ]]; then
+	if $do_report; then
 		_make_testcase_report "$section" "$test_seq" \
 				      "$test_status" "$((stop - start))"
 	fi
common/report +1 -1
index 64f9c866..399c6a0e 100644
@@ -97,7 +97,7 @@ _xunit_make_testcase_report()
 			echo -e "\t\t<skipped/>" >> $report
 		fi
 		;;
-	"list")
+	"list"|"expunge")
 		echo -e "\t\t<skipped/>" >> $report
 		;;
 	"fail")
Signature · 1 line
2.39.0