fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
PATCH 1/1 fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
These functions returns boolean value not wide character.
Signed-off-by Pali Rohár <[email protected]>
--- fs/fat/namei_vfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/fat/namei_vfat.c +2 -2
@@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {/* Characters that are undesirable in an MS-DOS file name */ -static inline wchar_t vfat_bad_char (wchar_t w) +static inline bool vfat_bad_char (wchar_t w) {return (w <0x0020 ) || (w =='*' ) || (w =='?' ) || (w =='<' ) || (w =='>' )
@@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w) || (w == '\\'); } -static inline wchar_t vfat_replace_char (wchar_t w) +static inline bool vfat_replace_char (wchar_t w) {return (w =='[' ) || (w ==']' ) || (w ==';' ) || (w ==',' ) || (w =='+' ) || (w =='=' );
Signature · 1 line
2.20.1
Quoted 3 lines · Pali Rohár
These functions returns boolean value not wide character.
Signed-off-by Pali Rohár <[email protected]>
Thanks.
Acked-by OGAWA Hirofumi <[email protected]>
Quoted 26 lines
--- fs/fat/namei_vfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/fat/namei_vfat.c +2
-2@@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {/* Characters that are undesirable in an MS-DOS file name */ -static inline wchar_t vfat_bad_char (wchar_t w) +static inline bool vfat_bad_char (wchar_t w) {return (w <0x0020 ) || (w =='*' ) || (w =='?' ) || (w =='<' ) || (w =='>' )@@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w) || (w == '\\'); } -static inline wchar_t vfat_replace_char (wchar_t w) +static inline bool vfat_replace_char (wchar_t w) {return (w =='[' ) || (w ==']' ) || (w ==';' ) || (w ==',' ) || (w =='+' ) || (w =='=' );
Signature · 1 line
OGAWA Hirofumi <[email protected]>