scsi: smartpqi: use strscpy() to instead of strncpy()
Subsystems (2)
PATCH 1/1 scsi: smartpqi: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL-terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/scsi/smartpqi/smartpqi_init.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/scsi/smartpqi/smartpqi_init.c +2 -3
@@ -996,9 +996,8 @@ static int pqi_write_driver_version_to_host_wellness( buffer->driver_version_tag[1 ] ='V' ;put_unaligned_le16 (sizeof (buffer->driver_version), &buffer->driver_version_length); -strncpy (buffer->driver_version,"Linux " DRIVER_VERSION , -sizeof (buffer->driver_version) -1 ); - buffer->driver_version[sizeof (buffer->driver_version) -1 ] ='\0' ; +strscpy (buffer->driver_version,"Linux " DRIVER_VERSION , +sizeof (buffer->driver_version)); buffer->dont_write_tag[0 ] ='D' ; buffer->dont_write_tag[1 ] ='W' ; buffer->end_tag[0 ] ='Z' ;
Signature · 1 line
2.15.2