Skip to contentSkip to conversation

musl: Update to latest on tip of trunk

PATCH In review Khem Raj 3 participants 6 messages Dec 29, 2022 – Jan 6, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 musl: Update to latest on tip of trunk

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage libc.page_size
* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso relocating itself
* b50eb8c3 fix strverscmp comparison of digit sequence with non-digits
* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no result but no error
* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as an error
* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with MT-fork
* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is passed
* d8f35e29 fix AS-safety of close when aio is in use and fd map is expanded
* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at thread exit
* 36b72cd6 fix potential deadlock in dlerror buffer handling at thread exit
* 833a4691 configure: disable TBAA optimization because most compilers are buggy
* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from _GNU_SOURCE
* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker remapping
* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to handle long CNAMEs
* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under 512 bytes
* c87d75f2 adapt res_msend DNS query core for working with multiple sockets
* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish NODATA vs NxDomain

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +1 -1
index a72d87ea6f..7749495ec6 100644
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
 BASEVER = "1.2.3"
 
Signature · 1 line
2.39.0
#1 lore raw
Quoted 40 lines · Khem Raj

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage libc.page_size
* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso relocating itself
* b50eb8c3 fix strverscmp comparison of digit sequence with non-digits
* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no result but no error
* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as an error
* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with MT-fork
* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is passed
* d8f35e29 fix AS-safety of close when aio is in use and fd map is expanded
* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at thread exit
* 36b72cd6 fix potential deadlock in dlerror buffer handling at thread exit
* 833a4691 configure: disable TBAA optimization because most compilers are buggy
* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from _GNU_SOURCE
* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker remapping
* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to handle long CNAMEs
* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under 512 bytes
* c87d75f2 adapt res_msend DNS query core for working with multiple sockets
* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish NODATA vs NxDomain

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +0 -0
index a72d87ea6f..7749495ec6 100644

meta/recipes-core/musl/musl_git.bb line 10

Quoted 8 lines
meta/recipes-core/musl/musl_git.bb +1 -1
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
 BASEVER = "1.2.3"
 

I tested this with your 3 musl patches and it showed a few issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/6421
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6439

Cheers,

Richard

author
#2 lore raw
Quoted 48 lines · Richard Purdie
Quoted 46 lines · Khem Raj

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage libc.page_size
* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso relocating itself
* b50eb8c3 fix strverscmp comparison of digit sequence with non-digits
* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no result but no error
* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as an error
* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with MT-fork
* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is passed
* d8f35e29 fix AS-safety of close when aio is in use and fd map is expanded
* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at thread exit
* 36b72cd6 fix potential deadlock in dlerror buffer handling at thread exit
* 833a4691 configure: disable TBAA optimization because most compilers are buggy
* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from _GNU_SOURCE
* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker remapping
* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to handle long CNAMEs
* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under 512 bytes
* c87d75f2 adapt res_msend DNS query core for working with multiple sockets
* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish NODATA vs NxDomain

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +1 -1
index a72d87ea6f..7749495ec6 100644
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
Quoted 8 lines

meta/recipes-core/musl/musl_git.bb line 10

Quoted 2 lines
meta/recipes-core/musl/musl_git.bb +0 -0
 BASEVER = "1.2.3"
 

I tested this with your 3 musl patches and it showed a few issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/6421
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6439

I have sent fixes for all the build failures seen in these two builds.

Thanks
-Khem

#3 lore raw
Quoted 70 lines · Khem Raj
Quoted 5 lines · Richard Purdie
Quoted 3 lines · Khem Raj

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage

libc.page_size

Quoted 2 lines
Quoted 2 lines

* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso

relocating itself

Quoted 3 lines
Quoted 3 lines

* b50eb8c3 fix strverscmp comparison of digit sequence with non-digits
* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no result

but no error

Quoted 2 lines
Quoted 2 lines

* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as an

error

Quoted 4 lines
Quoted 4 lines

* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with MT-fork
* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is passed
* d8f35e29 fix AS-safety of close when aio is in use and fd map is

expanded

Quoted 3 lines
Quoted 3 lines

* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at

thread exit

Quoted 1 line
Quoted 1 line

* 36b72cd6 fix potential deadlock in dlerror buffer handling at thread

exit

Quoted 1 line
Quoted 1 line

* 833a4691 configure: disable TBAA optimization because most compilers

are buggy

Quoted 2 lines
Quoted 2 lines

* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from

_GNU_SOURCE

Quoted 1 line
Quoted 1 line

* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker

remapping

Quoted 2 lines
Quoted 2 lines

* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to handle

long CNAMEs

Quoted 3 lines
Quoted 3 lines

* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under 512

bytes

Quoted 1 line
Quoted 1 line

* c87d75f2 adapt res_msend DNS query core for working with multiple

sockets

Quoted 1 line
Quoted 1 line

* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish

NODATA vs NxDomain

Quoted 7 lines

Review

Quoted 7 lines
---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/musl/musl_git.bb

Quoted 15 lines

meta/recipes-core/musl/musl_git.bb line 10

Quoted 12 lines

index a72d87ea6f..7749495ec6 100644

meta/recipes-core/musl/musl_git.bb +1 -1
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
 BASEVER = "1.2.3"
 

I tested this with your 3 musl patches and it showed a few issues:

Quoted 6 lines
Quoted 3 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/6421
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6439

I have sent fixes for all the build failures seen in these two builds.

I am getting other failures since this patch was merged (
https://github.com/ndechesne/meta-qcom/actions/workflows/daily.yml). When building e2fsprog for arm 32 bit targets. A snippet of the build log is:

| arm-poky-linux-musleabi-gcc -mthumb -mfpu=neon-vfpv4 -mfloat-abi=hard
-mcpu=cortex-a15 -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat
-Wformat-security -Werror=format-security --sysroot=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot
-I. -I../../lib -I../../../git/lib -O2 -pipe -g
-feliminate-unused-debug-types -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0
-fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0 -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0 -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0 -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot= -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot= -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot-native= -pthread -DHAVE_CONFIG_H -c ../../../git/lib/ext2fs/lookup.c -o lookup.o
| ../../../git/lib/ext2fs/llseek.c:70:22: error: expected declaration
specifiers or '...' before '_llseek'
| 70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned
long,offset_high,

|       |                      ^~~~~~~
| ../../../git/lib/ext2fs/llseek.c:70:43: error: unknown type name 'fd'
|    70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned
long,offset_high,
|       |                                           ^~
| ../../../git/lib/ext2fs/llseek.c:70:60: error: unknown type name

'offset_high'
| 70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned
long,offset_high,
| |
^~~~~~~~~~~
| ../../../git/lib/ext2fs/llseek.c:71:33: error: unknown type name 'offset_low'; did you mean 'offsetof'?

|    71 |                  unsigned long, offset_low,ext2_loff_t *,result,
|       |                                 ^~~~~~~~~~
|       |                                 offsetof
| ../../../git/lib/ext2fs/llseek.c:71:58: error: unknown type name 'result'
|    71 |                  unsigned long, offset_low,ext2_loff_t *,result,
|       |                                                          ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:72:32: error: unknown type name 'origin'
|    72 |                  unsigned int, origin);
|       |                                ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:67:12: warning: '_llseek' used but never
defined
|    67 | static int _llseek (unsigned int, unsigned long,
|       |            ^~~~~~~
| make[2]: *** [Makefile:689: llseek.o] Error 1

The last known good build was with acef849931c5ab14ede40c2ea01a22027e34a335, first failure was caught with 64625155eca8399f403b992ec536897f75956baa (both are Poky tree sha).

Quoted 14 lines

Thanks
-Khem

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#175178):
https://lists.openembedded.org/g/openembedded-core/message/175178
Mute This Topic: https://lists.openembedded.org/mt/95933622/1279857
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#4 lore raw
Quoted 94 lines · Nicolas Dechesne
Quoted 56 lines · Khem Raj
Quoted 53 lines · Richard Purdie
Quoted 40 lines · Khem Raj

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage libc.page_size
* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso relocating itself
* b50eb8c3 fix strverscmp comparison of digit sequence with non-digits
* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no result but no error
* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as an error
* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with MT-fork
* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is passed
* d8f35e29 fix AS-safety of close when aio is in use and fd map is expanded
* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at thread exit
* 36b72cd6 fix potential deadlock in dlerror buffer handling at thread exit
* 833a4691 configure: disable TBAA optimization because most compilers are buggy
* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from _GNU_SOURCE
* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker remapping
* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to handle long CNAMEs
* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under 512 bytes
* c87d75f2 adapt res_msend DNS query core for working with multiple sockets
* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish NODATA vs NxDomain

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +0 -0
index a72d87ea6f..7749495ec6 100644

meta/recipes-core/musl/musl_git.bb line 10

Quoted 8 lines
meta/recipes-core/musl/musl_git.bb +1 -1
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
 BASEVER = "1.2.3"
 

I tested this with your 3 musl patches and it showed a few issues:

Quoted 5 lines
Quoted 3 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/6421
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6439

I have sent fixes for all the build failures seen in these two builds.

I am getting other failures since this patch was merged (https://github.com/ndechesne/meta-qcom/actions/workflows/daily.yml). When building e2fsprog for arm 32 bit targets. A snippet of the build log is:

| arm-poky-linux-musleabi-gcc  -mthumb -mfpu=neon-vfpv4 -mfloat-abi=hard -mcpu=cortex-a15 -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot -I. -I../../lib -I../../../git/lib  -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0  -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0  -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0  -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0  -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot=  -fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot=  -fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot-native=  -pthread  -DHAVE_CONFIG_H  -c ../../../git/lib/ext2fs/lookup.c -o lookup.o
| ../../../git/lib/ext2fs/llseek.c:70:22: error: expected declaration specifiers or '...' before '_llseek'
|    70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned long,offset_high,
|       |                      ^~~~~~~
| ../../../git/lib/ext2fs/llseek.c:70:43: error: unknown type name 'fd'
|    70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned long,offset_high,
|       |                                           ^~
| ../../../git/lib/ext2fs/llseek.c:70:60: error: unknown type name 'offset_high'
|    70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned long,offset_high,
|       |                                                            ^~~~~~~~~~~
| ../../../git/lib/ext2fs/llseek.c:71:33: error: unknown type name 'offset_low'; did you mean 'offsetof'?
|    71 |                  unsigned long, offset_low,ext2_loff_t *,result,
|       |                                 ^~~~~~~~~~
|       |                                 offsetof
| ../../../git/lib/ext2fs/llseek.c:71:58: error: unknown type name 'result'
|    71 |                  unsigned long, offset_low,ext2_loff_t *,result,
|       |                                                          ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:72:32: error: unknown type name 'origin'
|    72 |                  unsigned int, origin);
|       |                                ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:67:12: warning: '_llseek' used but never defined
|    67 | static int _llseek (unsigned int, unsigned long,
|       |            ^~~~~~~
| make[2]: *** [Makefile:689: llseek.o] Error 1
Quoted 2 lines

The last known good build was with acef849931c5ab14ede40c2ea01a22027e34a335, first failure was caught with 64625155eca8399f403b992ec536897f75956baa (both are Poky tree sha).

Interesting, it compiled ok for qemuarm and also for rpi4(32bit), I will try to reproduce it here.

Quoted 12 lines
Quoted 12 lines

Thanks
-Khem

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175178): https://lists.openembedded.org/g/openembedded-core/message/175178
Mute This Topic: https://lists.openembedded.org/mt/95933622/1279857
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#5 lore raw
Quoted 143 lines · Khem Raj
Quoted 5 lines · Nicolas Dechesne
Quoted 1 line · Khem Raj
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines · Richard Purdie
Quoted 3 lines · Khem Raj

Brings following changes

* f47a8cdd ldso: fix invalid early references to extern-linkage

libc.page_size

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* 377218cb pthread_atfork: fix return value on malloc failure
* 29e43191 fix double-processing of DT_RELR relocations in ldso

relocating itself

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* b50eb8c3 fix strverscmp comparison of digit sequence with

non-digits

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* ad5dcd39 fix async thread cancellation stack alignment
* 8f925945 fix return value of gethostby{name[2],addr} with no

result but no error

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* 63402be2 clean up dns_parse_callback
* 0a7b4323 dns response handling: don't treat too many addresses as

an error

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* 41603c77 dns response handling: ignore presence of wrong-type RRs
* cf76df0e fix missing synchronization of pthread TSD keys with

MT-fork

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* 5ff3eea9 fgets: avoid arithmetic overflow when n==INT_MIN is

passed

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* d8f35e29 fix AS-safety of close when aio is in use and fd map is

expanded

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

* 26c76a90 fix use of uninitialized dummy_fut in aio_suspend
* aebd6a36 fix potential deadlock between multithreaded fork and aio
* d64148a8 fix potential unsynchronized access to killlock state at

thread exit

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* 36b72cd6 fix potential deadlock in dlerror buffer handling at

thread exit

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* 833a4691 configure: disable TBAA optimization because most

compilers are buggy

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* e6e82132 disable MADV_FREE usage in mallocng
* 25e6fee2 remove LFS64 programming interfaces (macro-only) from

_GNU_SOURCE

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* 246f1c81 remove LFS64 symbol aliases; replace with dynamic linker

remapping

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* dec8f0a4 dns query core: detect udp truncation at recv time
* 8c408937 getaddrinfo dns lookup: use larger answer buffer to

handle long CNAMEs

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

* 759bf785 arpa/nameser.h: update RR types list
* 51d4669f dns: implement tcp fallback in __res_msend query core
* e2e95176 res_send: use a temp buffer if caller's buffer is under

512 bytes

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* c87d75f2 adapt res_msend DNS query core for working with multiple

sockets

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

* 85050ac5 getaddrinfo: add EAI_NODATA error code to distinguish

NODATA vs NxDomain

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Review

Quoted 7 lines
---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/musl/musl_git.bb

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

index a72d87ea6f..7749495ec6 100644

meta/recipes-core/musl/musl_git.bb +1 -1
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "dc9285ad1dc19349c407072cc48ba70dab86de45"
+SRCREV = "f47a8cdd250d9163fcfb39bf4e9d813957c0b187"
 
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

meta/recipes-core/musl/musl_git.bb line 10

Quoted 2 lines
meta/recipes-core/musl/musl_git.bb +0 -0
 BASEVER = "1.2.3"
 

I tested this with your 3 musl patches and it showed a few issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/6421

Quoted 1 line
Quoted 1 line
Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/6439

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

I have sent fixes for all the build failures seen in these two builds.

I am getting other failures since this patch was merged (

https://github.com/ndechesne/meta-qcom/actions/workflows/daily.yml). When building e2fsprog for arm 32 bit targets. A snippet of the build log is:

Quoted 2 lines

| arm-poky-linux-musleabi-gcc -mthumb -mfpu=neon-vfpv4 -mfloat-abi=hard

(quoted diff) +0 -13
-mcpu=cortex-a15 -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat
-Wformat-security -Werror=format-security
--sysroot=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot
-I. -I../../lib -I../../../git/lib  -O2 -pipe -g
-feliminate-unused-debug-types
-fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0
-fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/git=/usr/src/debug/e2fsprogs/1.46.5-r0
-fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0
-fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/build=/usr/src/debug/e2fsprogs/1.46.5-r0
-fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot=
-fmacro-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot=
-fdebug-prefix-map=/oe/build/tmp/work/cortexa15t2hf-neon-vfpv4-poky-linux-musleabi/e2fsprogs/1.46.5-r0/recipe-sysroot-native=
-pthread  -DHAVE_CONFIG_H  -c ../../../git/lib/ext2fs/lookup.c -o lookup.o
Quoted 1 line

| ../../../git/lib/ext2fs/llseek.c:70:22: error: expected declaration

specifiers or '...' before '_llseek'

Quoted 1 line

| 70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned

long,offset_high,

Quoted 3 lines
|       |                      ^~~~~~~
| ../../../git/lib/ext2fs/llseek.c:70:43: error: unknown type name 'fd'
|    70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned

long,offset_high,

Quoted 2 lines
|       |                                           ^~
| ../../../git/lib/ext2fs/llseek.c:70:60: error: unknown type name

'offset_high'

Quoted 1 line

| 70 | static _syscall5(int,_llseek,unsigned int,fd,unsigned

long,offset_high,

Quoted 1 line

| |

^~~~~~~~~~~

Quoted 1 line

| ../../../git/lib/ext2fs/llseek.c:71:33: error: unknown type name

'offset_low'; did you mean 'offsetof'?

Quoted 1 line

| 71 | unsigned long, offset_low,ext2_loff_t

*,result,

Quoted 3 lines
|       |                                 ^~~~~~~~~~
|       |                                 offsetof
| ../../../git/lib/ext2fs/llseek.c:71:58: error: unknown type name

'result'

Quoted 1 line

| 71 | unsigned long, offset_low,ext2_loff_t

*,result,

Quoted 2 lines
|       |                                                          ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:72:32: error: unknown type name

'origin'

Quoted 3 lines
|    72 |                  unsigned int, origin);
|       |                                ^~~~~~
| ../../../git/lib/ext2fs/llseek.c:67:12: warning: '_llseek' used but

never defined

Quoted 4 lines
|    67 | static int _llseek (unsigned int, unsigned long,
|       |            ^~~~~~~
| make[2]: *** [Makefile:689: llseek.o] Error 1
Quoted 8 lines
Quoted 1 line

The last known good build was with

acef849931c5ab14ede40c2ea01a22027e34a335, first failure was caught with 64625155eca8399f403b992ec536897f75956baa (both are Poky tree sha).

Quoted 1 line

Interesting, it compiled ok for qemuarm and also for rpi4(32bit), I will try to reproduce it here.

I am seeing the same problem in my poky/qemuarm CI:
https://ci.linaro.org/job/lt-qcom-poky-master/604/DISTRO=poky,MACHINE=qemuarm,TCLIBC=musl/console

Note that both meta-qcom and poky/qemu are using the Linaro Tux cloud infrastructure to build.. I will try a local build as well.

Quoted 16 lines
Quoted 8 lines
Quoted 8 lines

Thanks
-Khem

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#175178):

https://lists.openembedded.org/g/openembedded-core/message/175178

Quoted 3 lines
Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/95933622/1279857
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines
Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-