Skip to contentSkip to conversation

btrfs: Fix ASSERT of em->len when getting extent

PATCH In review Tanmay Bhushan 3 participants 3 messages Dec 31, 2022 – Jan 3, 2023 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: Fix ASSERT of em->len when getting extent

em->len is incorrectly asserted which is leading to it's assignment to sectorsize instead of being check for it.

---
 fs/btrfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/inode.c +1 -1
index 8bcad9940154..e49358048a98 100644
@@ -7092,7 +7092,7 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
 		 * Other members are not utilized for inline extents.
 		 */
 		ASSERT(em->block_start == EXTENT_MAP_INLINE);
-		ASSERT(em->len = fs_info->sectorsize);
+		ASSERT(em->len == fs_info->sectorsize);
 
 		ret = read_inline_extent(inode, path, page);
 		if (ret < 0)
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Tanmay Bhushan
Quoted 13 lines · Tanmay Bhushan

em->len is incorrectly asserted which is leading to it's assignment to sectorsize instead of being check for it.

---
  fs/btrfs/inode.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/inode.c +0 -0
index 8bcad9940154..e49358048a98 100644

fs/btrfs/inode.c struct extent_map *btrfs_get_extent(struct btrfs_inode *inode, · line 7095

Quoted 5 lines
fs/btrfs/inode.c +1 -1
@@ -7092,7 +7092,7 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
  		 * Other members are not utilized for inline extents.
  		 */
  		ASSERT(em->block_start == EXTENT_MAP_INLINE);
-		ASSERT(em->len = fs_info->sectorsize);
+		ASSERT(em->len == fs_info->sectorsize);

Good catch.

Quoted 3 lines
fs/btrfs/inode.c +0 -0
  		ret = read_inline_extent(inode, path, page);
  		if (ret < 0)