irqchip: Fix refcount leak in platform_irqchip_probe
PATCH 1/1 irqchip: Fix refcount leak in platform_irqchip_probe
of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/irqchip/irqchip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/irqchip/irqchip.c +6 -2
@@ -38,8 +38,10 @@ int platform_irqchip_probe(struct platform_device *pdev)struct device_node *par_np =of_irq_find_parent (np);of_irq_init_cb_t irq_init_cb =of_device_get_match_data (&pdev->dev); -if (!irq_init_cb) +if (!irq_init_cb) { +of_node_put (par_np);return -EINVAL ; + }if (par_np == np) par_np =NULL ;
@@ -52,8 +54,10 @@ int platform_irqchip_probe(struct platform_device *pdev)* interrupt controller. The actual initialization callback of this * interrupt controller can check for specific domains as necessary. */ -if (par_np && !irq_find_matching_host (par_np,DOMAIN_BUS_ANY )) +if (par_np && !irq_find_matching_host (par_np,DOMAIN_BUS_ANY )) { +of_node_put (par_np);return -EPROBE_DEFER ; + }return irq_init_cb (np, par_np); }
Signature · 1 line
2.25.1
Quoted 7 lines · Miaoqian Lin
of_irq_find_parent()returns a node pointer with refcount incremented, We should useof_node_put()on it when not needed anymore. Add missingof_node_put()to avoid refcount leak.Fixes f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/ENDand
IRQCHIP_MATCHhelper macros")Signed-off-by Miaoqian Lin <[email protected]>
Please stop sending these patches one by one.
Send a series covering the whole of the irqchip subsystem, once you have looked at all the drivers.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 6caa5a2b78f5f53c433d3a3781e53325da22f0ac Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/6caa5a2b78f5f53c433d3a3781e53325da22f0ac Author: Miaoqian Lin <[email protected]> AuthorDate: Mon, 02 Jan 2023 16:13:18 +04:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sun, 05 Feb 2023 11:07:52
irqchip: Fix refcount leak in platform_irqchip_probe
of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/irqchip/irqchip.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/irqchip/irqchip.c +6 -2
@@ -38,8 +38,10 @@ int platform_irqchip_probe(struct platform_device *pdev)struct device_node *par_np =of_irq_find_parent (np);of_irq_init_cb_t irq_init_cb =of_device_get_match_data (&pdev->dev); -if (!irq_init_cb) +if (!irq_init_cb) { +of_node_put (par_np);return -EINVAL ; + }if (par_np == np) par_np =NULL ;
@@ -52,8 +54,10 @@ int platform_irqchip_probe(struct platform_device *pdev)* interrupt controller. The actual initialization callback of this * interrupt controller can check for specific domains as necessary. */ -if (par_np && !irq_find_matching_host (par_np,DOMAIN_BUS_ANY )) +if (par_np && !irq_find_matching_host (par_np,DOMAIN_BUS_ANY )) { +of_node_put (par_np);return -EPROBE_DEFER ; + }return irq_init_cb (np, par_np); }