Skip to contentSkip to conversation

stress-ng: Do not enforce gold linker

PATCH In review Khem Raj 2 participants 2 messages Jan 3, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 stress-ng: Do not enforce gold linker

This can then be controlled by yocto environment through LDFLAGS if needed since we support multiple linkers and distro policy may want a different linker, moreover gold fails on ppc32 to link since its missing

Fixes errors like below on ppc/gold + clang

/usr/lib/clang/15.0.6/lib/linux/libclang_rt.builtins-powerpc.a(mulsc3.c.o): unsupported -mbss-plt code

---
 meta/recipes-extended/stress-ng/stress-ng_0.15.01.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-extended/stress-ng/stress-ng_0.15.01.bb +2 -0
index 38fd6698b3..72893e7893 100644
@@ -23,6 +23,8 @@ EXTRA_OEMAKE = "VERBOSE=1"
 do_configure() {
     mkdir -p configs
     touch configs/HAVE_APPARMOR
+    # Disable forcing gold linker
+    sed -i -e '/LD_GOLD/{N;d;}' ${S}/Makefile.config
     oe_runmake makeconfig
 }
 
Signature · 1 line
2.39.0
#1 lore raw

Can this be made a patch and submitted upstream? Patching like that with sed is prone to silent regressions.

Alex

Quoted 39 lines · Khem Raj

This can then be controlled by yocto environment through LDFLAGS if needed since we support multiple linkers and distro policy may want a different linker, moreover gold fails on ppc32 to link since its missing

Fixes errors like below on ppc/gold + clang

/usr/lib/clang/15.0.6/lib/linux/libclang_rt.builtins-powerpc.a(mulsc3.c.o): unsupported -mbss-plt code

---
 meta/recipes-extended/stress-ng/stress-ng_0.15.01.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-extended/stress-ng/stress-ng_0.15.01.bb +2 -1
index 38fd6698b3..72893e7893 100644
@@ -23,6 +23,8 @@ EXTRA_OEMAKE = "VERBOSE=1"
 do_configure() {
     mkdir -p configs
     touch configs/HAVE_APPARMOR
+    # Disable forcing gold linker
+    sed -i -e '/LD_GOLD/{N;d;}' ${S}/Makefile.config
     oe_runmake makeconfig
 }
 
--

2.39.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175334): https://lists.openembedded.org/g/openembedded-core/message/175334
Mute This Topic: https://lists.openembedded.org/mt/96024589/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-