Skip to contentSkip to conversation

dt-bindings: rtc: qcom-pm8xxx: allow 'wakeup-source' property

PATCH Applied Johan Hovold 3 participants 3 messages Jan 4, 2023 – Jan 9, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: rtc: qcom-pm8xxx: allow 'wakeup-source' property

The RTC can be used as a wakeup source on at least some platforms so allow it to be described as such.

---

Since commit 30d70ec8f7fd ("arm64: dts: qcom: sa8295p-adp: Add RTC node") this triggers a warning on DT validation so it would be nice to get this into 6.2:

arch/arm64/boot/dts/qcom/sa8295p-adp.dtb: rtc@6000: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'

Johan

 Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml +2 -0
index 0a7aa29563c1..21c8ea08ff0a 100644
@@ -40,6 +40,8 @@ properties:
     description:
       Indicates that the setting of RTC time is allowed by the host CPU.
 
+  wakeup-source: true
+
 required:
   - compatible
   - reg
Signature · 1 line
2.37.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Johan Hovold

The RTC can be used as a wakeup source on at least some platforms so allow it to be described as such.

---

Since commit 30d70ec8f7fd ("arm64: dts: qcom: sa8295p-adp: Add RTC node") this triggers a warning on DT validation so it would be nice to get this into 6.2:

Quoted 8 lines

arch/arm64/boot/dts/qcom/sa8295p-adp.dtb: rtc@6000: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'

Johan

 Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 2 ++
 1 file changed, 2 insertions(+)
maintainer Applied
#2 lore raw
In reply to Johan Hovold
Quoted 4 lines · Johan Hovold

The RTC can be used as a wakeup source on at least some platforms so allow it to be described as such.

Applied, thanks!

[1/1] dt-bindings: rtc: qcom-pm8xxx: allow 'wakeup-source' property

      commit: 51b3802e79606b2326f4a8cac0f2766a2e15338b

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com