Skip to contentSkip to conversation

s390x: Fix integer literal in skey.c

PATCH In review Nina Schoetterl-Glausch 2 participants 3 messages Jan 4, 2023 – Jan 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x: Fix integer literal in skey.c

The code is a 64bit number of which the upper 48 bits must be 0.

---
 s390x/skey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/skey.c +1 -1
index 1167e4d3..7c7a8090 100644
@@ -320,7 +320,7 @@ static void test_diag_308(void)
 		"lr	%[response],%%r3\n"
 		: [response] "=d" (response)
 		: [ipib] "d" (ipib),
-		  [code] "d" (5)
+		  [code] "d" (5L)
 		: "%r2", "%r3"
 	);
 	report(response == 0x402, "no exception on fetch, response: invalid IPIB");

base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea

Signature · 1 line
2.36.1
#1 lore raw

I forgot:

Fixes 965e38a0 ("s390x: Test effect of storage keys on diag 308")
Quoted 22 lines · Nina Schoetterl-Glausch

The code is a 64bit number of which the upper 48 bits must be 0.

---
 s390x/skey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/skey.c +1 -1
index 1167e4d3..7c7a8090 100644
@@ -320,7 +320,7 @@ static void test_diag_308(void)
 		"lr	%[response],%%r3\n"
 		: [response] "=d" (response)
 		: [ipib] "d" (ipib),
-		  [code] "d" (5)
+		  [code] "d" (5L)
 		: "%r2", "%r3"
 	);
 	report(response == 0x402, "no exception on fetch, response: invalid IPIB");

base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea

#2 lore raw
In reply to Nina Schoetterl-Glausch
Quoted 21 lines · Nina Schoetterl-Glausch

The code is a 64bit number of which the upper 48 bits must be 0.

---
  s390x/skey.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
s390x/skey.c +1 -1
index 1167e4d3..7c7a8090 100644
@@ -320,7 +320,7 @@ static void test_diag_308(void)
  		"lr	%[response],%%r3\n"
  		: [response] "=d" (response)
  		: [ipib] "d" (ipib),
-		  [code] "d" (5)
+		  [code] "d" (5L)
  		: "%r2", "%r3"
  	);
  	report(response == 0x402, "no exception on fetch, response: invalid IPIB");
Quoted 1 line

base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea

Thanks, I've pushed it directly as a trivial fix.

Thomas