sunxi: f1c100s: re-enable SYSRESET
PATCH 1/1 sunxi: f1c100s: re-enable SYSRESET
The SoC .dtsi originally submitted for the Allwinner F1C100s had the wrong compatible string for the watchdog, which broke U-Boot's reset functionality. To quickly fix this, we disable CONFIG_SYSRESET in cfcf1952c11e6ffcbbf88 ("sunxi: f1c100s: Drop SYSRESET to enable reset functionality"), so that U-Boot's hardcoded reset driver could take over.
After this was properly fixed in the devicetree, we reverted that patch in 92373de041ea ("Revert "sunxi: f1c100s: Drop SYSRESET to enable reset functionality"), however this line sneaked back in with d0ee7f295d74 ("Convert CONFIG_SYS_PBSIZE to Kconfig"), so during a Kconfig update.
Remove this line (again), to use the proper reset driver.
---
Hi,
this is not critical (so nothing for 2023.01), reset works either way. But we should fix it anyway.
Cheers,
Andre
configs/licheepi_nano_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/licheepi_nano_defconfig +0 -1
@@ -10,4 +10,3 @@ CONFIG_SPL_SPI_SUNXI=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_SPI_FLASH_XTX=y CONFIG_SPI=y -# CONFIG_SYSRESET is not set
Signature · 1 line
2.35.5
Quoted 18 lines · Andre Przywara
The SoC .dtsi originally submitted for the Allwinner F1C100s had the wrong compatible string for the watchdog, which broke U-Boot's reset functionality. To quickly fix this, we disable
CONFIG_SYSRESETincfcf1952c11e6ffcbbf88("sunxi: f1c100s: Drop SYSRESET to enable reset functionality"), so that U-Boot's hardcoded reset driver could take over.After this was properly fixed in the devicetree, we reverted that patch in
92373de041ea("Revert "sunxi: f1c100s: Drop SYSRESET to enable reset functionality"), however this line sneaked back in withd0ee7f295d74("ConvertCONFIG_SYS_PBSIZEtoKconfig"), so during aKconfigupdate.Remove this line (again), to use the proper reset driver.
Fixes d0ee7f295d74 ("Convert CONFIG_SYS_PBSIZE to Kconfig")Signed-off-by Andre Przywara <[email protected]>---
Hi,
Quoted 8 lines
this is not critical (so nothing for 2023.01), reset works either way. But we should fix it anyway.
Cheers,
Andreconfigs/licheepi_nano_defconfig | 1 - 1 file changed, 1 deletion(-)