Skip to contentSkip to conversation

cifs: remove redundant assignment to the variable match

PATCH New Colin Ian King 1 participant 1 message Jan 5, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: remove redundant assignment to the variable match

The variable match is being assigned a value that is never read, it is being re-assigned a new value later on. The assignment is redundant and can be removed.

Cleans up clang scan-build warning:
fs/cifs/dfs_cache.c:1302:2: warning: Value stored to 'match' is never read

---
 fs/cifs/dfs_cache.c | 1 -
 1 file changed, 1 deletion(-)
fs/cifs/dfs_cache.c +0 -1
index 43ad1176dcb9..e20f8880363f 100644
@@ -1299,7 +1299,6 @@ static bool target_share_equal(struct TCP_Server_Info *server, const char *s1, c
 	 * Resolve share's hostname and check if server address matches.  Otherwise just ignore it
 	 * as we could not have upcall to resolve hostname or failed to convert ip address.
 	 */
-	match = true;
 	extract_unc_hostname(s1, &host, &hostlen);
 	scnprintf(unc, sizeof(unc), "\\\\%.*s", (int)hostlen, host);
 
Signature · 1 line
2.30.2