Skip to contentSkip to conversation

soc: qcom: dcc: Fix unsigned comparison with less than zero

PATCH Applied Yang Li 2 participants 2 messages Jan 6, 2023

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 soc: qcom: dcc: Fix unsigned comparison with less than zero

The return value from the call to kstrtouint_from_user() is int. However, the return value is being assigned to
an unsigned int variable 'ret', so making 'ret' an int.

Eliminate the following warning:
./drivers/soc/qcom/dcc.c:815:5-8: WARNING: Unsigned expression compared with zero: ret < 0

---
 drivers/soc/qcom/dcc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/qcom/dcc.c +2 -1
index d4101f79cb5d..5b50d638771d 100644
@@ -808,7 +808,8 @@ static ssize_t config_reset_write(struct file *filp,
 				  const char __user *user_buf, size_t count,
 				  loff_t *ppos)
 {
-	unsigned int val, ret;
+	unsigned int val;
+	int ret;
 	struct dcc_drvdata *drvdata = filp->private_data;
 
 	ret = kstrtouint_from_user(user_buf, count, 0, &val);
Signature · 1 line
2.20.1.7.g153144c
maintainer Applied
#1 lore raw
Quoted 8 lines · Yang Li

The return value from the call to kstrtouint_from_user() is int. However, the return value is being assigned to
an unsigned int variable 'ret', so making 'ret' an int.

Eliminate the following warning:
./drivers/soc/qcom/dcc.c:815:5-8: WARNING: Unsigned expression compared with zero: ret < 0

[...]

Applied, thanks!

[1/1] soc: qcom: dcc: Fix unsigned comparison with less than zero

      commit: d4b2c7484a8edd79c90b9f8acc8a03e5e3235b89

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>