Fixed warnings
Subsystems (3)
v6 cover Fixed warnings
Fixed warnings related to PTR_ERR and initialization.
Divya Koppera (2):
net: phy: micrel: Fixed error related to uninitialized symbol ret
net: phy: micrel: Fix warn: passing zero to PTR_ERR
drivers/net/phy/micrel.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
--
2.17.1
PATCH v6 1/2 net: phy: micrel: Fixed error related to uninitialized symbol ret
Initialized return variable
Fixes Old smatch warnings:drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
uninitialized symbol 'ret'.
---
v5 -> v6:
- Removed fixes tag as this is fixing static analysis issus and not a real fix.
v4 -> v5:
- No changes, added reviewed by tag.
v3 -> v4:
- Split the patch for different warnings.
v1 -> v3:
- No changes
--- drivers/net/phy/micrel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/micrel.c +2 -1
@@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,const struct kszphy_type *type = phydev->drv->driver_data;unsigned long pair_mask = type->pair_mask;int retries =20 ; -int pair, ret; +int ret =0 ; +int pair; *finished = false;
Signature · 1 line
2.17.1
PATCH v6 2/2 net: phy: micrel: Fix warn: passing zero to PTR_ERR
In reply to Divya KopperaHandle the NULL pointer case
Fixes New smatch warnings:drivers/net/phy/micrel.c:2613 lan8814_ptp_probe_once() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +2613 drivers/net/phy/micrel.c
---
v5 -> v6:
- Removed fixes tag as this is to fix static analysis issues and not real fix.
v4 -> v5:
- Removed run time check and added compile time check for PHC
v3 -> v4:
- Split the patch for different warnings
- Renamed variable from shared_priv to shared.
v2 -> v3:
- Changed subject line from net to net-next
- Removed config check for ptp and clock configuration instead added null check for ptp_clock
- Fixed one more warning related to initialisaton.
v1 -> v2:
- Handled NULL pointer case
- Changed subject line with net-next to net
--- drivers/net/phy/micrel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/phy/micrel.c +5 -5
@@ -3017,10 +3017,6 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev) {struct lan8814_shared_priv *shared = phydev->shared->priv; -if (!IS_ENABLED (CONFIG_PTP_1588_CLOCK ) || - !IS_ENABLED (CONFIG_NETWORK_PHY_TIMESTAMPING )) -return 0 ; -/* Initialise shared lock for clock*/ mutex_init (&shared->shared_lock);
@@ -3040,12 +3036,16 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev) shared->ptp_clock =ptp_clock_register (&shared->ptp_clock_info, &phydev->mdio.dev); -if (IS_ERR_OR_NULL (shared->ptp_clock)) { +if (IS_ERR (shared->ptp_clock)) {phydev_err (phydev,"ptp_clock_register failed %lu\n" ,PTR_ERR (shared->ptp_clock));return -EINVAL ; } +/* Check if PHC support is missing at the configuration level */ +if (!shared->ptp_clock) +return 0 ; +phydev_dbg (phydev,"successfully registered ptp clock\n" ); shared->phydev = phydev;
Signature · 1 line
2.17.1
Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
In reply to Divya KopperaHi Divya,
Quoted 10 lines · Divya Koppera
Initialized return variable
Fixes Old smatch warnings:
drivers/net/phy/micrel.c:1750ksz886x_cable_test_get_status()error:
uninitialized symbol 'ret'.Reported-by kernel test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>Reviewed-by Andrew Lunn <[email protected]>Signed-off-by Divya Koppera <[email protected]>
I think, Reviewed-by tag should come after signed-off tag. It should be in chronological order.
This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 10 lines · On Fri, 6 Jan 2023 13:59:03 +0530 you wrote:
Fixed warnings related to
PTR_ERRand initialization.Divya Koppera (2):
net: phy: micrel: Fixed error related to uninitialized symbol ret
net: phy: micrel: Fix warn: passing zero toPTR_ERRdrivers/net/phy/micrel.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)[...]
Here is the summary with links:
- [v6,net-next,1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
https://git.kernel.org/netdev/net-next/c/d50ede4f53e1 - [v6,net-next,2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR https://git.kernel.org/netdev/net-next/c/3f88d7d1be42
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html