liburing micro-optimzation
cover liburing micro-optimzation
From: Ammar Faizi <[email protected]>
Hi Jens,
This series contains liburing micro-optimzation. There are two patches in this series:
## Patch 1
- Fix bloated memset due to unexpected vectorization.
Clang and GCC generate an insane vectorized memset() in nolibc.c. liburing doesn't need such a powerful memset(). Add an empty inline ASM to prevent the compilers from over-optimizing the memset().
## Patch 2
- Simplify io_uring_register_file_alloc_range() function. Use a struct initializer instead of memset(). It simplifies the C code plus effectively reduces the code size.
---
Ammar Faizi (2):
nolibc: Fix bloated memset due to unexpected vectorization
register: Simplify io_uring_register_file_alloc_range() function
src/nolibc.c | 9 ++++++++- src/register.c | 9 ++++----- 2 files changed, 12 insertions(+), 6 deletions(-)
base-commit: c76d392035fd271980faa297334268f2cd77d774
Signature · 1 line
Ammar Faizi
PATCH 1/2 nolibc: Fix bloated memset due to unexpected vectorization
From: Ammar Faizi <[email protected]>
Clang and GCC generate an insane vectorized memset() in nolibc.c. liburing doesn't need such a powerful memset(). Add an empty inline ASM to prevent the compilers from over-optimizing the memset().
Just for comparison, see the following Assembly code (generated by Clang).
Before this patch:
```
0000000000003a00 <__uring_memset>:
3a00: mov %rdi,%rax
3a03: test %rdx,%rdx
3a06: je 3b2c <__uring_memset+0x12c>
3a0c: cmp $0x8,%rdx
3a10: jae 3a19 <__uring_memset+0x19>
3a12: xor %ecx,%ecx
3a14: jmp 3b20 <__uring_memset+0x120>
3a19: movzbl %sil,%r8d
3a1d: cmp $0x20,%rdx
3a21: jae 3a2a <__uring_memset+0x2a>
3a23: xor %ecx,%ecx
3a25: jmp 3ae0 <__uring_memset+0xe0>
3a2a: mov %rdx,%rcx
3a2d: and $0xffffffffffffffe0,%rcx
3a31: movd %r8d,%xmm0
3a36: punpcklbw %xmm0,%xmm0
3a3a: pshuflw $0x0,%xmm0,%xmm0
3a3f: pshufd $0x0,%xmm0,%xmm0
3a44: lea -0x20(%rcx),%rdi
3a48: mov %rdi,%r10
3a4b: shr $0x5,%r10
3a4f: inc %r10
3a52: mov %r10d,%r9d
3a55: and $0x3,%r9d
3a59: cmp $0x60,%rdi
3a5d: jae 3a63 <__uring_memset+0x63>
3a5f: xor %edi,%edi
3a61: jmp 3aa9 <__uring_memset+0xa9>
3a63: and $0xfffffffffffffffc,%r10
3a67: xor %edi,%edi
3a69: nopl 0x0(%rax)
3a70: movdqu %xmm0,(%rax,%rdi,1)
3a75: movdqu %xmm0,0x10(%rax,%rdi,1)
3a7b: movdqu %xmm0,0x20(%rax,%rdi,1)
3a81: movdqu %xmm0,0x30(%rax,%rdi,1)
3a87: movdqu %xmm0,0x40(%rax,%rdi,1)
3a8d: movdqu %xmm0,0x50(%rax,%rdi,1)
3a93: movdqu %xmm0,0x60(%rax,%rdi,1)
3a99: movdqu %xmm0,0x70(%rax,%rdi,1)
3a9f: sub $0xffffffffffffff80,%rdi
3aa3: add $0xfffffffffffffffc,%r10
3aa7: jne 3a70 <__uring_memset+0x70>
3aa9: test %r9,%r9
3aac: je 3ad6 <__uring_memset+0xd6>
3aae: lea (%rdi,%rax,1),%r10
3ab2: add $0x10,%r10
3ab6: shl $0x5,%r9
3aba: xor %edi,%edi
3abc: nopl 0x0(%rax)
3ac0: movdqu %xmm0,-0x10(%r10,%rdi,1)
3ac7: movdqu %xmm0,(%r10,%rdi,1)
3acd: add $0x20,%rdi
3ad1: cmp %rdi,%r9
3ad4: jne 3ac0 <__uring_memset+0xc0>
3ad6: cmp %rdx,%rcx
3ad9: je 3b2c <__uring_memset+0x12c>
3adb: test $0x18,%dl
3ade: je 3b20 <__uring_memset+0x120>
3ae0: mov %rcx,%rdi
3ae3: mov %rdx,%rcx
3ae6: and $0xfffffffffffffff8,%rcx
3aea: movd %r8d,%xmm0
3aef: punpcklbw %xmm0,%xmm0
3af3: pshuflw $0x0,%xmm0,%xmm0
3af8: nopl 0x0(%rax,%rax,1)
3b00: movq %xmm0,(%rax,%rdi,1)
3b05: add $0x8,%rdi
3b09: cmp %rdi,%rcx
3b0c: jne 3b00 <__uring_memset+0x100>
3b0e: cmp %rdx,%rcx
3b11: je 3b2c <__uring_memset+0x12c>
3b13: data16 data16 data16 cs nopw 0x0(%rax,%rax,1)
3b20: mov %sil,(%rax,%rcx,1)
3b24: inc %rcx
3b27: cmp %rcx,%rdx
3b2a: jne 3b20 <__uring_memset+0x120>
3b2c: ret
3b2d: nopl (%rax)
```After this patch:
```
0000000000003424 <__uring_memset>:
3424: mov %rdi,%rax
3427: test %rdx,%rdx
342a: je 343a <__uring_memset+0x16>
342c: xor %ecx,%ecx
342e: mov %sil,(%rax,%rcx,1)
3432: inc %rcx
3435: cmp %rcx,%rdx
3438: jne 342e <__uring_memset+0xa>
343a: ret
```--- src/nolibc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
src/nolibc.c +8 -1
@@ -12,9 +12,16 @@ void *__uring_memset(void *s, int c, size_t n)size_t i;unsigned char *p = s; -for (i =0 ; i < n; i++) +for (i =0 ; i < n; i++) { p[i] = (unsigned char ) c; +/* +* An empty inline ASM to avoid auto-vectorization +* because it's too bloated for liburing. +*/ + __asm__volatile ("" ); + } +return s; }
Signature · 1 line
Ammar Faizi
Re: [PATCH liburing v1 1/2] nolibc: Fix bloated memset due to unexpected vectorization
Quoted 106 lines · Ammar Faizi
Clang and GCC generate an insane vectorized
memset()innolibc.c. liburing doesn't need such a powerfulmemset(). Add an empty inline ASM to prevent the compilers from over-optimizing thememset().Just for comparison, see the following Assembly code (generated by Clang).
Before this patch:
``` 0000000000003a00 <__uring_memset>: 3a00: mov %rdi,%rax 3a03: test %rdx,%rdx 3a06: je 3b2c <__uring_memset+0x12c> 3a0c: cmp $0x8,%rdx 3a10: jae 3a19 <__uring_memset+0x19> 3a12: xor %ecx,%ecx 3a14: jmp 3b20 <__uring_memset+0x120> 3a19: movzbl %sil,%r8d 3a1d: cmp $0x20,%rdx 3a21: jae 3a2a <__uring_memset+0x2a> 3a23: xor %ecx,%ecx 3a25: jmp 3ae0 <__uring_memset+0xe0> 3a2a: mov %rdx,%rcx 3a2d: and $0xffffffffffffffe0,%rcx 3a31: movd %r8d,%xmm0 3a36: punpcklbw %xmm0,%xmm0 3a3a: pshuflw $0x0,%xmm0,%xmm0 3a3f: pshufd $0x0,%xmm0,%xmm0 3a44: lea -0x20(%rcx),%rdi 3a48: mov %rdi,%r10 3a4b: shr $0x5,%r10 3a4f: inc %r10 3a52: mov %r10d,%r9d 3a55: and $0x3,%r9d 3a59: cmp $0x60,%rdi 3a5d: jae 3a63 <__uring_memset+0x63> 3a5f: xor %edi,%edi 3a61: jmp 3aa9 <__uring_memset+0xa9> 3a63: and $0xfffffffffffffffc,%r10 3a67: xor %edi,%edi 3a69: nopl 0x0(%rax) 3a70: movdqu %xmm0,(%rax,%rdi,1) 3a75: movdqu %xmm0,0x10(%rax,%rdi,1) 3a7b: movdqu %xmm0,0x20(%rax,%rdi,1) 3a81: movdqu %xmm0,0x30(%rax,%rdi,1) 3a87: movdqu %xmm0,0x40(%rax,%rdi,1) 3a8d: movdqu %xmm0,0x50(%rax,%rdi,1) 3a93: movdqu %xmm0,0x60(%rax,%rdi,1) 3a99: movdqu %xmm0,0x70(%rax,%rdi,1) 3a9f: sub $0xffffffffffffff80,%rdi 3aa3: add $0xfffffffffffffffc,%r10 3aa7: jne 3a70 <__uring_memset+0x70> 3aa9: test %r9,%r9 3aac: je 3ad6 <__uring_memset+0xd6> 3aae: lea (%rdi,%rax,1),%r10 3ab2: add $0x10,%r10 3ab6: shl $0x5,%r9 3aba: xor %edi,%edi 3abc: nopl 0x0(%rax) 3ac0: movdqu %xmm0,-0x10(%r10,%rdi,1) 3ac7: movdqu %xmm0,(%r10,%rdi,1) 3acd: add $0x20,%rdi 3ad1: cmp %rdi,%r9 3ad4: jne 3ac0 <__uring_memset+0xc0> 3ad6: cmp %rdx,%rcx 3ad9: je 3b2c <__uring_memset+0x12c> 3adb: test $0x18,%dl 3ade: je 3b20 <__uring_memset+0x120> 3ae0: mov %rcx,%rdi 3ae3: mov %rdx,%rcx 3ae6: and $0xfffffffffffffff8,%rcx 3aea: movd %r8d,%xmm0 3aef: punpcklbw %xmm0,%xmm0 3af3: pshuflw $0x0,%xmm0,%xmm0 3af8: nopl 0x0(%rax,%rax,1) 3b00: movq %xmm0,(%rax,%rdi,1) 3b05: add $0x8,%rdi 3b09: cmp %rdi,%rcx 3b0c: jne 3b00 <__uring_memset+0x100> 3b0e: cmp %rdx,%rcx 3b11: je 3b2c <__uring_memset+0x12c> 3b13: data16 data16 data16 cs nopw 0x0(%rax,%rax,1) 3b20: mov %sil,(%rax,%rcx,1) 3b24: inc %rcx 3b27: cmp %rcx,%rdx 3b2a: jne 3b20 <__uring_memset+0x120> 3b2c: ret 3b2d: nopl (%rax) ```After this patch:
``` 0000000000003424 <__uring_memset>: 3424: mov %rdi,%rax 3427: test %rdx,%rdx 342a: je 343a <__uring_memset+0x16> 342c: xor %ecx,%ecx 342e: mov %sil,(%rax,%rcx,1) 3432: inc %rcx 3435: cmp %rcx,%rdx 3438: jne 342e <__uring_memset+0xa> 343a: ret ```
Quoted 1 line
Signed-off-by Ammar Faizi <[email protected]>
PATCH 2/2 register: Simplify `io_uring_register_file_alloc_range()` function
In reply to Ammar FaiziFrom: Ammar Faizi <[email protected]>
Use a struct initializer instead of memset(). It simplifies the C code plus effectively reduces the code size.
Extra bonus on x86-64. It reduces the stack allocation because it doesn't need to allocate stack for the local variable @range. It can just use 128 bytes of redzone below the %rsp (redzone is only available in a leaf function).
Before this patch:
```
0000000000003910 <io_uring_register_file_alloc_range>:
3910: push %rbp
3911: push %r15
3913: push %r14
3915: push %rbx
3916: sub $0x18,%rsp
391a: mov %edx,%r14d
391d: mov %esi,%ebp
391f: mov %rdi,%rbx
3922: lea 0x8(%rsp),%r15
3927: mov $0x10,%edx
392c: mov %r15,%rdi
392f: xor %esi,%esi
3931: call 3a00 <__uring_memset>
3936: mov %ebp,0x8(%rsp)
393a: mov %r14d,0xc(%rsp)
393f: mov 0xc4(%rbx),%edi
3945: mov $0x1ab,%eax
394a: mov $0x19,%esi
394f: mov %r15,%rdx
3952: xor %r10d,%r10d
3955: syscall
3957: add $0x18,%rsp
395b: pop %rbx
395c: pop %r14
395e: pop %r15
3960: pop %rbp
3961: ret
3962: cs nopw 0x0(%rax,%rax,1)
396c: nopl 0x0(%rax)
```After this patch:
```
0000000000003910 <io_uring_register_file_alloc_range>:
3910: mov %esi,-0x10(%rsp) # set range.off
3914: mov %edx,-0xc(%rsp) # set range.len
3918: movq $0x0,-0x8(%rsp) # zero the resv
3921: mov 0xc4(%rdi),%edi
3927: lea -0x10(%rsp),%rdx
392c: mov $0x1ab,%eax
3931: mov $0x19,%esi
3936: xor %r10d,%r10d
3939: syscall
393b: ret
```--- src/register.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
src/register.c +4 -5
@@ -333,11 +333,10 @@ int io_uring_register_sync_cancel(struct io_uring *ring,int io_uring_register_file_alloc_range (struct io_uring *ring,unsigned off,unsigned len) { -struct io_uring_file_index_range range; - -memset (&range,0 ,sizeof (range)); - range.off = off; - range.len = len; +struct io_uring_file_index_range range = { + .off = off, + .len = len + }; return __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_FILE_ALLOC_RANGE, &range,
Signature · 1 line
Ammar Faizi
Re: [PATCH liburing v1 2/2] register: Simplify `io_uring_register_file_alloc_range()` function
Quoted 59 lines · Ammar Faizi
Use a struct initializer instead of
memset(). It simplifies the C code plus effectively reduces the code size.Extra bonus on x86-64. It reduces the stack allocation because it doesn't need to allocate stack for the local variable @range. It can just use 128 bytes of redzone below the
%rsp(redzone is only available in a leaf function).Before this patch:
``` 0000000000003910 <io_uring_register_file_alloc_range>: 3910: push %rbp 3911: push %r15 3913: push %r14 3915: push %rbx 3916: sub $0x18,%rsp 391a: mov %edx,%r14d 391d: mov %esi,%ebp 391f: mov %rdi,%rbx 3922: lea 0x8(%rsp),%r15 3927: mov $0x10,%edx 392c: mov %r15,%rdi 392f: xor %esi,%esi 3931: call 3a00 <__uring_memset> 3936: mov %ebp,0x8(%rsp) 393a: mov %r14d,0xc(%rsp) 393f: mov 0xc4(%rbx),%edi 3945: mov $0x1ab,%eax 394a: mov $0x19,%esi 394f: mov %r15,%rdx 3952: xor %r10d,%r10d 3955: syscall 3957: add $0x18,%rsp 395b: pop %rbx 395c: pop %r14 395e: pop %r15 3960: pop %rbp 3961: ret 3962: cs nopw 0x0(%rax,%rax,1) 396c: nopl 0x0(%rax) ```After this patch:
``` 0000000000003910 <io_uring_register_file_alloc_range>: 3910: mov %esi,-0x10(%rsp) # set range.off 3914: mov %edx,-0xc(%rsp) # set range.len 3918: movq $0x0,-0x8(%rsp) # zero the resv 3921: mov 0xc4(%rdi),%edi 3927: lea -0x10(%rsp),%rdx 392c: mov $0x1ab,%eax 3931: mov $0x19,%esi 3936: xor %r10d,%r10d 3939: syscall 393b: ret ```
Quoted 1 line
Signed-off-by Ammar Faizi <[email protected]>
Quoted 10 lines · Ammar Faizi
This series contains liburing micro-optimzation. There are two patches in this series:
## Patch 1
- Fix bloated memset due to unexpected vectorization.
Clang and GCC generate an insane vectorizedmemset()innolibc.c. liburing doesn't need such a powerfulmemset(). Add an empty inline ASM to prevent the compilers from over-optimizing thememset().[...]
Applied, thanks!
[1/2] nolibc: Fix bloated memset due to unexpected vectorization
commit: 913ca9a93fd67a5e5a911d71a33a6de7a1a41101
[2/2] register: Simplify `io_uring_register_file_alloc_range()` function
commit: 8ab80b483518d51903c9eed24cf0e1ba826010fcBest regards,
Signature · 1 line
Jens Axboe