Skip to contentSkip to conversation

f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()

PATCH Applied Chao Yu 2 participants 2 messages Jan 9, 2023 – Jan 30, 2023 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/1 f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()

f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check in f2fs_create_whiteout().

---
 fs/f2fs/namei.c | 3 ---
 1 file changed, 3 deletions(-)
fs/f2fs/namei.c +0 -3
index 6032589099ce..82923273f4bb 100644
@@ -926,9 +926,6 @@ static int f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir,
 static int f2fs_create_whiteout(struct user_namespace *mnt_userns,
 				struct inode *dir, struct inode **whiteout)
 {
-	if (unlikely(f2fs_cp_error(F2FS_I_SB(dir))))
-		return -EIO;
-
 	return __f2fs_tmpfile(mnt_userns, dir, NULL,
 				S_IFCHR | WHITEOUT_MODE, true, whiteout);
 }
Signature · 8 lines
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
#1 lore raw
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

Quoted 7 lines · On Mon, 9 Jan 2023 11:47:34 +0800 you wrote:

f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check in f2fs_create_whiteout().

---
 fs/f2fs/namei.c | 3 ---
 1 file changed, 3 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()

    https://git.kernel.org/jaegeuk/f2fs/c/8abe4be45132

You are awesome, thank you!

Signature · 10 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel