Skip to contentSkip to conversation

pinctrl: pinmux: Drop duplicate error message in pinmux_select()

PATCH In review Andy Shevchenko 2 participants 2 messages Jan 9, 2023 – Jan 10, 2023

Subsystems (2)
GPIO Pin control
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 pinctrl: pinmux: Drop duplicate error message in pinmux_select()

pinctrl_get_group_selector() prints an error message when group is not found in the list. No need to repeat this in the caller.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/pinmux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pinctrl/pinmux.c +1 -3
index 6bd7ac37a0e0..021382632608 100644
@@ -744,10 +744,8 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf,
 	}
 
 	ret = pinctrl_get_group_selector(pctldev, gname);
-	if (ret < 0) {
-		dev_err(pctldev->dev, "failed to get group selector for %s", gname);
+	if (ret < 0)
 		goto exit_free_buf;
-	}
 	gsel = ret;
 
 	ret = pmxops->set_mux(pctldev, fsel, gsel);
Signature · 1 line
2.35.1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

pinctrl_get_group_selector() prints an error message when group is not found in the list. No need to repeat this in the caller.

Signed-off-by Andy Shevchenko <[email protected]>

Patch applied!

Yours,
Linus Walleij