mm/sl{a,u}b: fix wrong usages of folio_page() for getting head pages
Subsystems (2)
PATCH 1/1 mm/sl{a,u}b: fix wrong usages of folio_page() for getting head pages
The standard idiom for getting head page of a given folio is '&folio->page', but some are wrongly using 'folio_page(folio, 0)' for the purpose. Fix those to use the idiom.
--- mm/slab.c | 4 ++-- mm/slub.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
mm/slab.c +2 -2
@@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)BUG_ON (!folio_test_slab (folio));__slab_clear_pfmemalloc (slab); -page_mapcount_reset (folio_page (folio,0 )); +page_mapcount_reset (&folio->page); folio->mapping =NULL ;/* Make the mapping reset visible before clearing the flag */ smp_wmb ();
@@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=1 << order;unaccount_slab (slab, order, cachep); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void kmem_rcu_free (struct rcu_head *head)
mm/slub.c +1 -1
@@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab += pages;unaccount_slab (slab, order, s); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void rcu_free_slab (struct rcu_head *h)
Signature · 1 line
2.25.1
Quoted 6 lines · SeongJae Park
The standard idiom for getting head page of a given folio is '
&folio->page', but some are wrongly using 'folio_page(folio, 0)' for the purpose. Fix those to use the idiom.Suggested-by Matthew Wilcox <[email protected]>Signed-off-by SeongJae Park <[email protected]>
Thanks, pushed to slab/for-6.3/cleanups
Quoted 40 lines
--- mm/slab.c | 4 ++-- mm/slub.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)mm/slab.c +2
-2@@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)BUG_ON (!folio_test_slab (folio));__slab_clear_pfmemalloc (slab); -page_mapcount_reset (folio_page (folio,0 )); +page_mapcount_reset (&folio->page); folio->mapping =NULL ;/* Make the mapping reset visible before clearing the flag */ smp_wmb ();@@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=1 << order;unaccount_slab (slab, order, cachep); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void kmem_rcu_free (struct rcu_head *head)mm/slub.c +1
-1@@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab += pages;unaccount_slab (slab, order, s); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void rcu_free_slab (struct rcu_head *h)
Quoted 38 lines · SeongJae Park
The standard idiom for getting head page of a given folio is '
&folio->page', but some are wrongly using 'folio_page(folio, 0)' for the purpose. Fix those to use the idiom.Suggested-by Matthew Wilcox <[email protected]>Signed-off-by SeongJae Park <[email protected]>--- mm/slab.c | 4 ++-- mm/slub.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)mm/slab.c +2
-2@@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)BUG_ON (!folio_test_slab (folio));__slab_clear_pfmemalloc (slab); -page_mapcount_reset (folio_page (folio,0 )); +page_mapcount_reset (&folio->page); folio->mapping =NULL ;/* Make the mapping reset visible before clearing the flag */ smp_wmb ();@@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=1 << order;unaccount_slab (slab, order, cachep); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void kmem_rcu_free (struct rcu_head *head)mm/slub.c +0
-0
mm/slub.c static void __free_slab(struct kmem_cache *s, struct slab *slab) · line 2072
Quoted 8 lines
mm/slub.c +1
-1@@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab += pages;unaccount_slab (slab, order, s); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void rcu_free_slab (struct rcu_head *h)
Signature · 3 lines
Thanks, David / dhildenb
Quoted 50 lines · SeongJae Park
The standard idiom for getting head page of a given folio is '
&folio->page', but some are wrongly using 'folio_page(folio, 0)' for the purpose. Fix those to use the idiom.Suggested-by Matthew Wilcox <[email protected]>Signed-off-by SeongJae Park <[email protected]>--- mm/slab.c | 4 ++-- mm/slub.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)mm/slab.c +2
-2@@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)BUG_ON (!folio_test_slab (folio));__slab_clear_pfmemalloc (slab); -page_mapcount_reset (folio_page (folio,0 )); +page_mapcount_reset (&folio->page); folio->mapping =NULL ;/* Make the mapping reset visible before clearing the flag */ smp_wmb ();@@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=1 << order;unaccount_slab (slab, order, cachep); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void kmem_rcu_free (struct rcu_head *head)mm/slub.c +1
-1@@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab)if (current->reclaim_state) current->reclaim_state->reclaimed_slab += pages;unaccount_slab (slab, order, s); -__free_pages (folio_page (folio,0 ), order); +__free_pages (&folio->page, order); }static void rcu_free_slab (struct rcu_head *h)Signature · 1 line
2.25.1
Thanks!