Skip to contentSkip to conversation

Trivial changes

PATCH In review Glenn Washburn 2 participants 5 messages Jan 10, 2023 – Jan 11, 2023

lore
Share & tools
lore
#0 lore raw

cover Trivial changes

Some spelling and spacing changes. Feel free to merge together or with other changes as desired.

Glenn

Glenn Washburn (3):
misc: Spelling fixes
misc: Fix spacing
misc: efi: Fix spacing

 grub-core/disk/loopback.c   |  2 +-
 grub-core/gdb/i386/idt.c    |  2 +-
 grub-core/gdb/i386/signal.c |  2 +-
 include/grub/efi/api.h      | 58 ++++++++++++++++++-------------------
 include/grub/partition.h    |  2 +-
 5 files changed, 33 insertions(+), 33 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/3 misc: Spelling fixes

---
 grub-core/gdb/i386/idt.c    | 2 +-
 grub-core/gdb/i386/signal.c | 2 +-
 include/grub/partition.h    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
grub-core/gdb/i386/idt.c +1 -1
index 69bfcb089c..43bde51a01 100644
@@ -1,4 +1,4 @@
-/* idt.c - routines for constructing IDT fot the GDB stub */
+/* idt.c - routines for constructing IDT for the GDB stub */
 /*
  *  Copyright (C) 2006  Lubomir Kundrak
  *
grub-core/gdb/i386/signal.c +1 -1
index 1ac3bbd183..b169c6b230 100644
@@ -1,4 +1,4 @@
-/* idt.c - routines for constructing IDT fot the GDB stub */
+/* idt.c - routines for constructing IDT for the GDB stub */
 /*
  *  Copyright (C) 2006  Lubomir Kundrak
  *
include/grub/partition.h +1 -1
index 8208cc7881..c4d71d0eea 100644
@@ -87,7 +87,7 @@ struct grub_partition
   /* The type partition map.  */
   grub_partition_map_t partmap;
 
-  /* The type of partition whne it's on MSDOS.
+  /* The type of partition when it's on MSDOS.
      Used for embedding detection.  */
   grub_uint8_t msdostype;
 };
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/3 misc: Fix spacing

In reply to Glenn Washburn
---
 grub-core/disk/loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/disk/loopback.c +1 -1
index 2cfc53a916..4635dcfdee 100644
@@ -89,7 +89,7 @@ grub_cmd_loopback (grub_extcmd_context_t ctxt, int argc, char **args)
 
   /* Check if `-d' was used.  */
   if (state[0].set)
-      return delete_loopback (args[0]);
+    return delete_loopback (args[0]);
 
   if (!state[1].set)
     type |= GRUB_FILE_TYPE_NO_DECOMPRESS;
Signature · 1 line
2.34.1
#3 lore raw

PATCH 3/3 misc: efi: Fix spacing

In reply to Glenn Washburn
---
 include/grub/efi/api.h | 58 +++++++++++++++++++++---------------------
 1 file changed, 29 insertions(+), 29 deletions(-)
include/grub/efi/api.h +29 -29
index 75efb4d4c2..9e17b675bb 100644
@@ -1077,8 +1077,8 @@ typedef struct grub_efi_input_key grub_efi_input_key_t;
 typedef grub_efi_uint8_t grub_efi_key_toggle_state_t;
 struct grub_efi_key_state
 {
-	grub_efi_uint32_t key_shift_state;
-	grub_efi_key_toggle_state_t key_toggle_state;
+  grub_efi_uint32_t key_shift_state;
+  grub_efi_key_toggle_state_t key_toggle_state;
 };
 typedef struct grub_efi_key_state grub_efi_key_state_t;
 
@@ -1170,10 +1170,10 @@ struct grub_efi_boot_services
 		grub_efi_timer_delay_t type,
 		grub_efi_uint64_t trigger_time);
 
-   grub_efi_status_t
-   (*wait_for_event) (grub_efi_uintn_t num_events,
-		      grub_efi_event_t *event,
-		      grub_efi_uintn_t *index);
+  grub_efi_status_t
+  (*wait_for_event) (grub_efi_uintn_t num_events,
+		     grub_efi_event_t *event,
+		     grub_efi_uintn_t *index);
 
   grub_efi_status_t
   (*signal_event) (grub_efi_event_t event);
@@ -1184,11 +1184,11 @@ struct grub_efi_boot_services
   grub_efi_status_t
   (*check_event) (grub_efi_event_t event);
 
-   grub_efi_status_t
-   (*install_protocol_interface) (grub_efi_handle_t *handle,
-				  grub_efi_guid_t *protocol,
-				  grub_efi_interface_type_t protocol_interface_type,
-				  void *protocol_interface);
+  grub_efi_status_t
+  (*install_protocol_interface) (grub_efi_handle_t *handle,
+				 grub_efi_guid_t *protocol,
+				 grub_efi_interface_type_t protocol_interface_type,
+				 void *protocol_interface);
 
   grub_efi_status_t
   (*reinstall_protocol_interface) (grub_efi_handle_t handle,
@@ -1454,29 +1454,29 @@ typedef grub_efi_status_t (*grub_efi_key_notify_function_t) (
 
 struct grub_efi_simple_text_input_ex_interface
 {
-	grub_efi_status_t
-	(*reset) (struct grub_efi_simple_text_input_ex_interface *this,
-		  grub_efi_boolean_t extended_verification);
+  grub_efi_status_t
+  (*reset) (struct grub_efi_simple_text_input_ex_interface *this,
+	    grub_efi_boolean_t extended_verification);
 
-	grub_efi_status_t
-	(*read_key_stroke) (struct grub_efi_simple_text_input_ex_interface *this,
-			    grub_efi_key_data_t *key_data);
+  grub_efi_status_t
+  (*read_key_stroke) (struct grub_efi_simple_text_input_ex_interface *this,
+		      grub_efi_key_data_t *key_data);
 
-	grub_efi_event_t wait_for_key;
+  grub_efi_event_t wait_for_key;
 
-	grub_efi_status_t
-	(*set_state) (struct grub_efi_simple_text_input_ex_interface *this,
-		      grub_efi_key_toggle_state_t *key_toggle_state);
+  grub_efi_status_t
+  (*set_state) (struct grub_efi_simple_text_input_ex_interface *this,
+	        grub_efi_key_toggle_state_t *key_toggle_state);
 
-	grub_efi_status_t
-	(*register_key_notify) (struct grub_efi_simple_text_input_ex_interface *this,
-				grub_efi_key_data_t *key_data,
-				grub_efi_key_notify_function_t key_notification_function,
-				void **notify_handle);
+  grub_efi_status_t
+  (*register_key_notify) (struct grub_efi_simple_text_input_ex_interface *this,
+			  grub_efi_key_data_t *key_data,
+			  grub_efi_key_notify_function_t key_notification_function,
+			  void **notify_handle);
 
-	grub_efi_status_t
-	(*unregister_key_notify) (struct grub_efi_simple_text_input_ex_interface *this,
-				  void *notification_handle);
+  grub_efi_status_t
+  (*unregister_key_notify) (struct grub_efi_simple_text_input_ex_interface *this,
+			    void *notification_handle);
 };
 typedef struct grub_efi_simple_text_input_ex_interface grub_efi_simple_text_input_ex_interface_t;
 
Signature · 1 line
2.34.1
#4 lore raw
In reply to Glenn Washburn
Quoted 9 lines · Glenn Washburn

Some spelling and spacing changes. Feel free to merge together or with other changes as desired.

Glenn

Glenn Washburn (3):
misc: Spelling fixes
misc: Fix spacing
misc: efi: Fix spacing

For all the patches Reviewed-by: Daniel Kiper <[email protected]>...

Daniel