Skip to contentSkip to conversation

gpio: davinci: Remove duplicate assignment of of_gpio_n_cells

PATCH Applied Andy Shevchenko 2 participants 2 messages Jan 12, 2023 – Jan 16, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: davinci: Remove duplicate assignment of of_gpio_n_cells

The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.

---
 drivers/gpio/gpio-davinci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-davinci.c +0 -1
index e1c1b9a527db..26b1f7465e09 100644
@@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 	chips->chip.base = pdata->no_auto_base ? pdata->base : -1;
 
 #ifdef CONFIG_OF_GPIO
-	chips->chip.of_gpio_n_cells = 2;
 	chips->chip.parent = dev;
 	chips->chip.request = gpiochip_generic_request;
 	chips->chip.free = gpiochip_generic_free;
Signature · 1 line
2.39.0
#1 lore raw
Quoted 22 lines · Andy Shevchenko

The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver.

---
 drivers/gpio/gpio-davinci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-davinci.c +0 -2
index e1c1b9a527db..26b1f7465e09 100644
@@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
        chips->chip.base = pdata->no_auto_base ? pdata->base : -1;
 
 #ifdef CONFIG_OF_GPIO
-       chips->chip.of_gpio_n_cells = 2;
        chips->chip.parent = dev;
        chips->chip.request = gpiochip_generic_request;
        chips->chip.free = gpiochip_generic_free;
--
Quoted 2 lines

2.39.0

Applied, thanks!

Bart