scsi: qla2xxx: Change qla_trim_buf,__qla_adjust_buf functions to static
Subsystems (2)
PATCH 1/1 scsi: qla2xxx: Change qla_trim_buf,__qla_adjust_buf functions to static
Smatch reportsdrivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static? drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static?
These functions are only used in qla_mid.c, so they should be static.
--- drivers/scsi/qla2xxx/qla_mid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_mid.c +2 -2
@@ -1186,7 +1186,7 @@ int qla_get_buf(struct scsi_qla_host *vha, struct qla_qpair *qp, struct qla_buf_return 0 ; } -void qla_trim_buf (struct qla_qpair *qp,u16 trim) +static void qla_trim_buf (struct qla_qpair *qp,u16 trim) {int i, j;struct qla_hw_data *ha = qp->vha->hw;
@@ -1218,7 +1218,7 @@ void qla_trim_buf(struct qla_qpair *qp, u16 trim) qp->id, trim, qp->buf_pool.num_alloc); } -void __qla_adjust_buf (struct qla_qpair *qp) +static void __qla_adjust_buf (struct qla_qpair *qp) {u32 trim;
Signature · 1 line
2.27.0
Martin K. Petersen
AppliedTom,
Quoted 5 lines
Smatch reports
drivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static?drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static?These functions are only used in
qla_mid.c, so they should be static.
Applied to 6.3/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 8 lines · Tom Rix
Smatch reports
drivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static?drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static?These functions are only used in
qla_mid.c, so they should be static.[...]
Applied to 6.3/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Change qla_trim_buf,__qla_adjust_buf functions to static
https://git.kernel.org/mkp/scsi/c/54c51253b3d5
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering