zsmalloc: avoid unused-function warning
Subsystems (2)
PATCH 1/1 zsmalloc: avoid unused-function warning
From: Arnd Bergmann <[email protected]>
obj_allocated() can be called from two places that are each inside of an #ifdef. When both are disabled, the compiler warns:
mm/zsmalloc.c:900:13: error: 'obj_allocated' defined but not used [-Werror=unused-function]
Rather than trying to figure out the correct #ifdef, mark the trivial function as 'inline', which implies __maybe_unused and shuts up the warning.
--- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/zsmalloc.c +1 -1
@@ -937,7 +937,7 @@ static bool obj_tagged(struct page *page, void *obj, unsigned long *phandle,return true; } -static bool obj_allocated (struct page *page,void *obj,unsigned long *phandle) +static inline bool obj_allocated (struct page *page,void *obj,unsigned long *phandle) {return obj_tagged (page, obj, phandle,OBJ_ALLOCATED_TAG ); }
Signature · 1 line
2.39.0
Quoted 11 lines · Arnd Bergmann
obj_allocated()can be called from two places that are each inside of an #ifdef. When both are disabled, the compiler warns:
mm/zsmalloc.c:900:13: error: 'obj_allocated' defined but not used [-Werror=unused-function]Rather than trying to figure out the correct #ifdef, mark the trivial function as 'inline', which implies
__maybe_unusedand shuts up the warning.Fixes 796c71ac728e ("zsmalloc: fix a race with deferred_handles storing")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
obj_allocated()can be called from two places that are each inside of an #ifdef. When both are disabled, the compiler warns:
Quoted 8 lines
mm/zsmalloc.c:900:13: error: 'obj_allocated' defined but not used [-Werror=unused-function]Rather than trying to figure out the correct #ifdef, mark the trivial function as 'inline', which implies
__maybe_unusedand shuts up the warning.Fixes 796c71ac728e ("zsmalloc: fix a race with deferred_handles storing")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 18 lines
--- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/zsmalloc.c +1
-2@@ -937,7 +937,7 @@ static bool obj_tagged(struct page *page, void *obj, unsigned long *phandle,return true; } -static bool obj_allocated (struct page *page,void *obj,unsigned long *phandle) +static inline bool obj_allocated (struct page *page,void *obj,unsigned long *phandle) {return obj_tagged (page, obj, phandle,OBJ_ALLOCATED_TAG ); } --
Quoted 2 lines
2.39.0
Tricky one indeed - I definitely missed that. Thanks for the fix!