nvme-pci: fix timoeut request state check
PATCH 1/1 nvme-pci: fix timoeut request state check
From: Keith Busch <[email protected]>
Polling the completion can progress the request state to IDLE, either inline with the completion, or through softirq. Either way, the state may not be COMPLETED, so don't check for that. We only care if the state isn't STARTED.
This is fixing an issue where the driver aborts an IO that we just completed. Seeing the "aborting" message instead of "polled" is very misleading as to where the timeout problem resides.
Fixes bf392a5dc02a9b ("nvme-pci: Remove tag from process cq")
Signed-off-by Keith Busch <[email protected]>
--- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -1
@@ -1362,7 +1362,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req)else nvme_poll_irqdisable (nvmeq); -if (blk_mq_request_completed (req)) { +if (!blk_mq_request_started (req)) {dev_warn (dev->ctrl.device,"I/O %d QID %d timeout, completion polled\n" , req->tag, nvmeq->qid);
Signature · 1 line
2.30.2