Skip to contentSkip to conversation

tools/intel_gpu_power: Intel GPU idle/busy power measurement

PATCH New Ashutosh Dixit 2 participants 2 messages Jan 19, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/intel_gpu_power: Intel GPU idle/busy power measurement

In several instances (e.g. when investigating GPU power limits) it is very useful to be able to measure GPU power easily. Since we already have all ingredients for doing so, add a tool to measure Intel GPU power when idle and power under load.

---
 tools/intel_gpu_power.c | 73 +++++++++++++++++++++++++++++++++++++++++
 tools/meson.build       |  1 +
 2 files changed, 74 insertions(+)
 create mode 100644 tools/intel_gpu_power.c
tools/intel_gpu_power.c new file +73 -0
new file mode 100644
index 00000000000..3f73e10bf60
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#include "igt.h"
+#include "i915/gem.h"
+#include "igt_power.h"
+
+static int measure_power(int i915, const char *domain, bool load)
+{
+	const intel_ctx_t *ctx = intel_ctx_create_all_physical(i915);
+	int ret, sleep_duration_sec = 2;
+	struct power_sample sample[2];
+	struct igt_power pwr;
+	igt_spin_t *spin;
+
+	gem_quiescent_gpu(i915);
+	if (load) {
+		spin = igt_spin_new(i915, .ctx = ctx, .engine = ALL_ENGINES,
+				    .flags = IGT_SPIN_POLL_RUN);
+		/* Wait till at least one spinner starts */
+		igt_spin_busywait_until_started(spin);
+	}
+
+	ret = igt_power_open(i915, &pwr, domain);
+	if (ret)
+		return ret;
+	igt_power_get_energy(&pwr, &sample[0]);
+	usleep(sleep_duration_sec * USEC_PER_SEC);
+	igt_power_get_energy(&pwr, &sample[1]);
+	igt_info("Measured power: %g mW\n", igt_power_get_mW(&pwr, &sample[0], &sample[1]));
+
+	igt_power_close(&pwr);
+	igt_free_spins(i915);
+	intel_ctx_destroy(i915, ctx);
+
+	return 0;
+}
+
+static void usage(const char *name)
+{
+	igt_info("Usage: %s [options]\n", name);
+	igt_info("-i/--idle  Measure idle power\n");
+	igt_info("-b/--busy  Measure power under load\n");
+}
+
+int main(int argc, char *argv[])
+{
+	int i915 = drm_open_driver_master(DRIVER_INTEL);
+	static struct option long_options[] = {
+		{"idle", 0, 0, 'i'},
+		{"busy", 0, 0, 'b'},
+		{ 0, 0, 0, 0 }
+	};
+	int opt = getopt_long(argc, argv, "ib", long_options, NULL);
+	int ret = 0;
+
+	switch (opt) {
+	case 'i':
+		ret = measure_power(i915, "gpu", false);
+		break;
+	case 'b':
+		ret = measure_power(i915, "gpu", true);
+		break;
+	default:
+		usage(argv[0]);
+		break;
+	}
+
+	close(i915);
+	return ret;
+}
tools/meson.build +1 -0
index d2defec8703..4bbbd993cac 100644
@@ -22,6 +22,7 @@ tools_progs = [
 	'intel_error_decode',
 	'intel_forcewaked',
 	'intel_gpu_frequency',
+	'intel_gpu_power',
 	'intel_firmware_decode',
 	'intel_framebuffer_dump',
 	'intel_gpu_time',
Signature · 1 line
2.38.0
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tools/intel_gpu_power: Intel GPU idle/busy power measurement (rev2)

== Series Details ==

== Series Details ==

Series: tools/intel_gpu_power: Intel GPU idle/busy power measurement (rev2)
URL : https://patchwork.freedesktop.org/series/113073/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12606 -> IGTPW_8372
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8372 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8372, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/index.html

Participating hosts (40 -> 40)
------------------------------

Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8372:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@slpc:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8372 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) +15 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@[email protected]
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12606/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-pnv-d510/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#5334] / [i915#7872])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- {bat-rpls-1}: [DMESG-FAIL][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12606/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html

#### Warnings ####

* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [FAIL][11] ([fdo#103375]) -> [INCOMPLETE][12] ([i915#4817])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12606/fi-rkl-11600/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/fi-rkl-11600/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7124 -> IGTPW_8372

CI-20190529: 20190529
CI_DRM_12606: f20b8fdc4658730ff546a9214dc922cb52d496b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8372: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/index.html
IGT_7124: 6090d0a62e9c087429320c6fd3b6735ff68fde71 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8372/index.html