Skip to contentSkip to conversation

travis.yml: Use the libfdt from the distro instead of the submodule

PATCH Superseded Thomas Huth 2 participants 3 messages Jan 19, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 travis.yml: Use the libfdt from the distro instead of the submodule

No need to compile-test third party submodules over and over again if we can simply use the pre-build library from the distribution instead.

---
 .travis.yml | 5 +++++
 1 file changed, 5 insertions(+)
.travis.yml +5 -0
index fb3baabca9..e24c99fdb9 100644
@@ -128,6 +128,7 @@ jobs:
           - libbrlapi-dev
           - libcacard-dev
           - libcap-ng-dev
+          - libfdt-dev
           - libgcrypt20-dev
           - libgnutls28-dev
           - libgtk-3-dev
@@ -162,6 +163,7 @@ jobs:
           - libbrlapi-dev
           - libcacard-dev
           - libcap-ng-dev
+          - libfdt-dev
           - libgcrypt20-dev
           - libgnutls28-dev
           - libgtk-3-dev
@@ -195,6 +197,7 @@ jobs:
           - libbrlapi-dev
           - libcacard-dev
           - libcap-ng-dev
+          - libfdt-dev
           - libgcrypt20-dev
           - libgnutls28-dev
           - libgtk-3-dev
@@ -237,6 +240,7 @@ jobs:
           - libattr1-dev
           - libcacard-dev
           - libcap-ng-dev
+          - libfdt-dev
           - libgnutls28-dev
           - libiscsi-dev
           - liblttng-ust-dev
@@ -281,6 +285,7 @@ jobs:
           - libbrlapi-dev
           - libcacard-dev
           - libcap-ng-dev
+          - libfdt-dev
           - libgcrypt20-dev
           - libgnutls28-dev
           - libgtk-3-dev
Signature · 1 line
2.31.1
#1 lore raw
Quoted 13 lines · Thomas Huth

No need to compile-test third party submodules over and over again if we can simply use the pre-build library from the distribution instead.

---
  .travis.yml | 5 +++++
  1 file changed, 5 insertions(+)
.travis.yml +0 -0
index fb3baabca9..e24c99fdb9 100644

.travis.yml jobs: · line 134

Quoted 7 lines
.travis.yml +1 -0
@@ -128,6 +128,7 @@ jobs:
            - libbrlapi-dev
            - libcacard-dev
            - libcap-ng-dev
+          - libfdt-dev
            - libgcrypt20-dev
            - libgnutls28-dev
            - libgtk-3-dev

Could we remove cloning the submodule in the 'enabled' case now? See ./configure:

1518 case "$fdt" in
1519 auto | enabled | internal)

1520       # Simpler to always update submodule, even if not needed.
1521       git_submodules="${git_submodules} dtc"
1522       ;;

1523 esac

#2 lore raw
Quoted 25 lines · Philippe Mathieu-Daudé
Quoted 13 lines · Thomas Huth

No need to compile-test third party submodules over and over again if we can simply use the pre-build library from the distribution instead.

---
  .travis.yml | 5 +++++

  1 file changed, 5 insertions(+)
.travis.yml +0 -0
index fb3baabca9..e24c99fdb9 100644
@@ -128,6 +128,7 @@ jobs:
Quoted 7 lines

            - libbrlapi-dev
            - libcacard-dev
            - libcap-ng-dev
+          - libfdt-dev
            - libgcrypt20-dev
            - libgnutls28-dev
            - libgtk-3-dev

Could we remove cloning the submodule in the 'enabled' case now? See ./configure:

Quoted 6 lines

1518  case "$fdt" in
1519    auto | enabled | internal)
1520       # Simpler to always update submodule, even if not needed. 1521       git_submodules="${git_submodules} dtc"
1522       ;;
1523  esac

I think currently "enabled" still means either "internal" or "system" ? ... so since we cannot know here yet whether there is a usable libfdt installed available or not, we cannot remove this yet.

If we want to avoid the unnecessary git cloning, we have to explicitly use --enable-fdt=system ... which would make sense here, indeed. I'll send a v2 with that added.

Thomas