Skip to contentSkip to conversation

drm/dma: Drop unbalanced obj unref

PATCH New Rob Clark 1 participant 1 message Jan 19, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/dma: Drop unbalanced obj unref

From: Rob Clark <[email protected]>

In the error path, drm_gem_dma_mmap() is dropping an obj reference that it doesn't own.

Fixes f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM CMA object functions")
---
 drivers/gpu/drm/drm_gem_dma_helper.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/drm_gem_dma_helper.c +0 -2
index 1e658c448366..784356d6f39d 100644
@@ -544,8 +544,6 @@ int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct *
 				  dma_obj->dma_addr,
 				  vma->vm_end - vma->vm_start);
 	}
-	if (ret)
-		drm_gem_vm_close(vma);
 
 	return ret;
 }
Signature · 1 line
2.38.1