Docs: Add missing SPDX license identifiers of
Subsystems (10)
v2 cover Docs: Add missing SPDX license identifiers of
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1
(https://lore.kernel.org/lkml/[email protected]/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)
SeongJae Park (8):
Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
Documentation/crypto/index.rst | 2 ++ Documentation/driver-api/index.rst | 2 ++ Documentation/gpu/index.rst | 2 ++ Documentation/hwmon/index.rst | 2 ++ Documentation/input/index.rst | 2 ++ Documentation/mm/index.rst | 2 ++ Documentation/scheduler/index.rst | 2 ++ Documentation/sound/index.rst | 2 ++ 8 files changed, 16 insertions(+)
Signature · 1 line
2.25.1
PATCH v2 3/8 Docs/gpu/index: Add missing SPDX License Identifier
Add missing SPDX License Identifier for gpu documentation index file.
--- Documentation/gpu/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/gpu/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: MIT + ============================ GPU Driver Developer's Guide ============================
Signature · 1 line
2.25.1
PATCH v2 1/8 Docs/crypto/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for crypto documentation index file.
--- Documentation/crypto/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/crypto/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ========== Crypto API ==========
Signature · 1 line
2.25.1
PATCH v2 2/8 Docs/driver-api/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for driver-api documentation index file.
--- Documentation/driver-api/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/driver-api/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ============================== Driver implementer's API guide ==============================
Signature · 1 line
2.25.1
PATCH v2 4/8 Docs/hwmon/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for hwmon documentation index file.
--- Documentation/hwmon/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/hwmon/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Hardware Monitoring ===================
Signature · 1 line
2.25.1
PATCH v2 6/8 Docs/mm/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for mm documentation index file.
--- Documentation/mm/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/mm/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =============================== Memory Management Documentation ===============================
Signature · 1 line
2.25.1
PATCH v2 5/8 Docs/input/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for input documentation index file.
--- Documentation/input/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/input/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Input Documentation ===================
Signature · 1 line
2.25.1
PATCH v2 7/8 Docs/scheduler/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for scheduler documentation index file.
--- Documentation/scheduler/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/scheduler/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ========= Scheduler =========
Signature · 1 line
2.25.1
PATCH v2 8/8 Docs/sound/index: Add missing SPDX License Identifier
In reply to SeongJae ParkAdd missing SPDX License Identifier for sound documentation index file.
--- Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)
Documentation/sound/index.rst +2 -0
@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ============================= Sound Subsystem Documentation =============================
Signature · 1 line
2.25.1
Re: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier
Quoted 4 lines · SeongJae Park
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by SeongJae Park <[email protected]>
thanks,
Takashi
Quoted 17 lines
--- Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/sound/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ============================= Sound Subsystem Documentation =============================Signature · 1 line
2.25.1
Jonathan Corbet
maintainerQuoted 2 lines · SeongJae Park
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Documentation/ is far behind on the SPDX front, and I'm all in favor of fixing that. I do worry, though, about sticking license declarations onto files that did not previously have them; do we know what the original contributor's intent was?
Quoted 16 lines
Changes from v1
(https://lore.kernel.org/lkml/[email protected]/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)SeongJae Park (8):
Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
Quoted 2 lines
Documentation/crypto/index.rst | 2 ++ Documentation/driver-api/index.rst | 2 ++
I added this one, and GPLv2 is fine there.
Quoted 7 lines
Documentation/gpu/index.rst | 2 ++ Documentation/hwmon/index.rst | 2 ++ Documentation/input/index.rst | 2 ++ Documentation/mm/index.rst | 2 ++ Documentation/scheduler/index.rst | 2 ++ Documentation/sound/index.rst | 2 ++ 8 files changed, 16 insertions(+)
Thanks,
jon
Re: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier
In reply to Takashi IwaiQuoted 8 lines · Takashi Iwai
Quoted 4 lines · SeongJae Park
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by SeongJae Park <[email protected]>Acked-by Takashi Iwai <[email protected]>
Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?
https://spdx.org/licenses/GPL-2.0.html
https://spdx.org/licenses/GPL-2.0-only.html
Quoted 23 lines
thanks,
Takashi
Quoted 17 lines
--- Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/sound/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ============================= Sound Subsystem Documentation =============================Signature · 1 line
2.25.1
Guenter Roeck
maintainerRe: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
In reply to SeongJae ParkQuoted 3 lines · SeongJae Park
Add missing SPDX License Identifier for hwmon documentation index file.
Signed-off-by SeongJae Park <[email protected]>
Is it documented somewhere that GPL 2.0 is the default in the absence of an explicit SPDX or other license identifier ? I don't find it in Documentation/process/license-rules.rst, though maybe I am missing it.
Guenter
Quoted 14 lines
--- Documentation/hwmon/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/hwmon/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Hardware Monitoring ===================
Jonathan Corbet
maintainerRe: [PATCH v2 8/8] Docs/sound/index: Add missing SPDX License Identifier
In reply to Pierre-Louis BossartQuoted 8 lines · Pierre-Louis Bossart
Quoted 7 lines · Takashi Iwai
Quoted 4 lines · SeongJae Park
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by SeongJae Park <[email protected]>
Quoted 7 lines
Quoted 1 line
Acked-by Takashi Iwai <[email protected]>Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?
The kernel community hasn't really followed along with that change on the part of the SPDX folks; as far as I know, GPL-2.0 is considered to be just fine. There are currently more than twice as many GPL-2.0 declarations than GPL-2.0-only.
Thanks,
jon
Jonathan Corbet
maintainerQuoted 9 lines · SeongJae Park
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1
(https://lore.kernel.org/lkml/[email protected]/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)
Quoted 9 lines
SeongJae Park (8):
Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
So I've applied patches 2 (since I wrote the initial file) and 8 (with Takashi's ack). The others are also fine, I think, but I hesitate to apply license texts to files without knowing that they match the author's intent. I hate to say it, but I think the best approach is to send each of the remaining patches to the appropriate maintainers for the subsystem involved.
Thanks,
jon
Quoted 21 lines · On Tue, 24 Jan 2023 15:31:04 -0700 Jonathan Corbet <[email protected]> wrote:
Quoted 9 lines · SeongJae Park
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1
(https://lore.kernel.org/lkml/[email protected]/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)Quoted 9 lines
SeongJae Park (8):
Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
Quoted 6 lines
So I've applied patches 2 (since I wrote the initial file) and 8 (with Takashi's ack). The others are also fine, I think, but I hesitate to apply license texts to files without knowing that they match the author's intent. I hate to say it, but I think the best approach is to send each of the remaining patches to the appropriate maintainers for the subsystem involved.
That makes 100% sense, thank you, Jon!
Thanks,
SJ
Quoted 4 lines
Thanks,
jon
Guenter Roeck
maintainerRe: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
In reply to SeongJae ParkQuoted 2 lines · SeongJae Park
Add missing SPDX License Identifier for hwmon documentation index file.
I do not feel comfortable accepting this change without confirmation that changing the license from <none> to an explicit <GPL v2.0> is legally acceptable.
Guenter
Quoted 15 lines
Signed-off-by SeongJae Park <[email protected]>--- Documentation/hwmon/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/hwmon/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Hardware Monitoring ===================
Jonathan Corbet
maintainerRe: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
Quoted 7 lines · Guenter Roeck
Quoted 2 lines · SeongJae Park
Add missing SPDX License Identifier for hwmon documentation index file.
I do not feel comfortable accepting this change without confirmation that changing the license from <none> to an explicit <GPL v2.0> is legally acceptable.
As with many of these, this file was initially added by Mauro (added to CC). Mauro, can you confirm that GPLv2 was your intention for these index.rst files? That would clear the path for a lot of these patches.
Thanks,
jon
Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
In reply to SeongJae ParkEm Sun, 22 Jan 2023 21:36:46 +0000
SeongJae Park <[email protected]> escreveu:
Quoted 3 lines
Add missing SPDX License Identifier for hwmon documentation index file.
Signed-off-by SeongJae Park <[email protected]>
Quoted 9 lines
--- Documentation/hwmon/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/hwmon/index.rst +0
-0
Documentation/hwmon/index.rst line 5
Quoted 5 lines
Documentation/hwmon/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Hardware Monitoring ===================
Thanks,
Mauro
Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
In reply to Jonathan CorbetEm Tue, 31 Jan 2023 07:44:02 -0700
Jonathan Corbet <[email protected]> escreveu:
Quoted 6 lines
Quoted 4 lines · Guenter Roeck
Quoted 2 lines · SeongJae Park
Add missing SPDX License Identifier for hwmon documentation index file.
Quoted 7 lines
Quoted 3 lines
I do not feel comfortable accepting this change without confirmation that changing the license from <none> to an explicit <GPL v2.0> is legally acceptable.
As with many of these, this file was initially added by Mauro (added to CC). Mauro, can you confirm that GPLv2 was your intention for these
index.rstfiles? That would clear the path for a lot of these patches.
Yes, that's the intend. Feel free to add either:
Or
to Documentation/*/index.rst files I wrote that might have missing:
.. SPDX-License-Identifier: GPL-2.0
on the top of it.
Thanks,
Mauro
Re: [PATCH v2 5/8] Docs/input/index: Add missing SPDX License Identifier
In reply to SeongJae ParkEm Sun, 22 Jan 2023 21:36:47 +0000
SeongJae Park <[email protected]> escreveu:
Quoted 3 lines
Add missing SPDX License Identifier for input documentation index file.
Signed-off-by SeongJae Park <[email protected]>
Quoted 9 lines
--- Documentation/input/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/input/index.rst +0
-0
Documentation/input/index.rst line 5
Quoted 5 lines
Documentation/input/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Input Documentation ===================
Thanks,
Mauro
Re: [PATCH v2 7/8] Docs/scheduler/index: Add missing SPDX License Identifier
In reply to SeongJae ParkEm Sun, 22 Jan 2023 21:36:49 +0000
SeongJae Park <[email protected]> escreveu:
Quoted 4 lines
Add missing SPDX License Identifier for scheduler documentation index file.
Signed-off-by SeongJae Park <[email protected]>
Quoted 9 lines
--- Documentation/scheduler/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/scheduler/index.rst +0
-0
Documentation/scheduler/index.rst line 5
Quoted 5 lines
Documentation/scheduler/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ========= Scheduler =========
Thanks,
Mauro
Re: [PATCH v2 4/8] Docs/hwmon/index: Add missing SPDX License Identifier
In reply to SeongJae ParkQuoted 4 lines · SeongJae Park
Add missing SPDX License Identifier for hwmon documentation index file.
Signed-off-by SeongJae Park <[email protected]>Reviewed-by Mauro Carvalho Chehab <[email protected]>
Applied to hwmon-next.
Thanks,
Guenter
Quoted 14 lines
--- Documentation/hwmon/index.rst | 2 ++ 1 file changed, 2 insertions(+)Documentation/hwmon/index.rst +2
-0@@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + =================== Hardware Monitoring ===================