openvpnmsica: remove unused declarations
PATCH 1/1 openvpnmsica: remove unused declarations
From: Lev Stipakov <[email protected]...>
That code has been moved to MSM by commit 640c4d82 ("openvpnmsica: remove dco installer custom actions")
Signed-off-by Lev Stipakov <[email protected]...>
--- src/openvpnmsica/openvpnmsica.h | 26 -------------------------- 1 file changed, 26 deletions(-)
src/openvpnmsica/openvpnmsica.h +0 -26
@@ -151,32 +151,6 @@ DLLEXP_DECL UINT __stdcall ProcessDeferredAction(_In_ MSIHANDLE hInstall); -/** -* Check what operation shall be performed on ovpn-dco driver -* and set data value (path to inf and user temp dir) for ProcessDriver action. -* -* @param hInstall Handle to the installation provided to the DLL custom action -* -* @return ERROR_SUCCESS on success; An error code otherwise -* See: https://msdn.microsoft.com/en-us/library/windows/desktop/aa368072.aspx -*/ -DLLEXP_DECL UINT __stdcall -EvaluateDriver(_In_ MSIHANDLE hInstall); - - -/** -* Install or uninstall ovpn-dco driver, removing all adapters using that driver. -* If reboot is required, creates reboot indication file in user's temp directory -* -* @param hInstall Handle to the installation provided to the DLL custom action -* -* @return ERROR_SUCCESS on success; An error code otherwise -* See: https://msdn.microsoft.com/en-us/library/windows/desktop/aa368072.aspx -*/ -DLLEXP_DECL UINT __stdcall -ProcessDriver(_In_ MSIHANDLE hInstall); - -/** * Schedule reboot after installation if reboot * indication file is found in user's temp directory
Signature · 1 line
2.38.1.windows.1
Acked-by Gert Doering <[email protected]...>
Quite straightforward - "if the code is gone, we do not need prototypes in .h files either" :-)
Not tested anything (beyond "push to mygithub" to be sure I did not overlook a ";" or anything).
Your patch has been applied to the master and release/2.6 branch.
commit 6effd9197cdbadedc19bb5e3254a1178697513ce (master) commit 5ddc7102b1b27b5b0f646d4c40c9d91b8e1989dd (release/2.6)
Author: Lev Stipakov Date: Tue Jan 24 11:14:41 2023 +0200
openvpnmsica: remove unused declarations
Signed-off-by: Lev Stipakov <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg26070.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering