Skip to contentSkip to conversation

nvme: fix passthrough csi check

PATCH Applied Keith Busch 2 participants 2 messages Jan 24, 2023 – Jan 25, 2023 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: fix passthrough csi check

From: Keith Busch <[email protected]>

The namespace head saves the Command Set Indicator enum, so use that instead of the Command Set Selected. The two values are not the same.

Fixes 831ed60c2aca2d ("nvme: also return I/O command effects from nvme_command_effects")
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index d307ae4d8a575..2990ed331a1aa 100644
@@ -1093,7 +1093,7 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode)
 	if (ns) {
 		if (ns->head->effects)
 			effects = le32_to_cpu(ns->head->effects->iocs[opcode]);
-		if (ns->head->ids.csi == NVME_CAP_CSS_NVM)
+		if (ns->head->ids.csi == NVME_CSI_NVM)
 			effects |= nvme_known_nvm_effects(opcode);
 		if (effects & ~(NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC))
 			dev_warn_once(ctrl->device,
Signature · 1 line
2.30.2