Skip to contentSkip to conversation

dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

PATCH In review Rob Herring 8 participants 11 messages Jan 24, 2023 – Jan 26, 2023

Subsystems (40)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---
To: Krzysztof Kozlowski <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Bartosz Golaszewski <[email protected]>
To: Jean Delvare <[email protected]>
To: Guenter Roeck <[email protected]>
To: Thomas Gleixner <[email protected]>
To: Marc Zyngier <[email protected]>
To: Jassi Brar <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Lee Jones <[email protected]>
To: Ulf Hansson <[email protected]>
To: Richard Weinberger <[email protected]>
To: Vignesh Raghavendra <[email protected]>
To: Sebastian Reichel <[email protected]>
To: Mark Brown <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Daniel Lezcano <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 .../devicetree/bindings/arm/arm,vexpress-juno.yaml     |  1 +
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml |  5 +++--
 .../bindings/arm/tegra/nvidia,tegra20-pmc.yaml         |  4 ++++
 .../bindings/bus/allwinner,sun50i-a64-de2.yaml         |  1 +
 .../bindings/bus/allwinner,sun8i-a23-rsb.yaml          |  1 +
 .../bus/intel,ixp4xx-expansion-bus-controller.yaml     |  6 ++++++
 Documentation/devicetree/bindings/bus/palmbus.yaml     |  1 +
 .../devicetree/bindings/display/msm/qcom,mdss.yaml     |  5 +++++
 Documentation/devicetree/bindings/example-schema.yaml  |  2 ++
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +
 .../devicetree/bindings/hwmon/adi,ltc2992.yaml         |  1 +
 .../bindings/interrupt-controller/arm,gic-v3.yaml      |  2 ++
 .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml      |  1 +
 .../devicetree/bindings/media/i2c/maxim,max9286.yaml   |  7 +++++++
 .../bindings/memory-controllers/arm,pl35x-smc.yaml     |  1 +
 .../bindings/memory-controllers/exynos-srom.yaml       |  1 +
 .../memory-controllers/nvidia,tegra124-emc.yaml        |  1 +
 .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml |  1 +
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml       |  2 ++
 .../devicetree/bindings/mmc/aspeed,sdhci.yaml          |  1 +
 Documentation/devicetree/bindings/mtd/mtd.yaml         |  1 +
 .../devicetree/bindings/power/supply/ti,lp8727.yaml    |  1 +
 .../devicetree/bindings/soc/imx/fsl,imx93-src.yaml     |  3 ++-
 .../bindings/soc/microchip/atmel,at91rm9200-tcb.yaml   |  1 +
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml |  1 +
 .../devicetree/bindings/sound/marvell,mmp-sspa.yaml    |  1 +
 .../devicetree/bindings/sound/qcom,wcd934x.yaml        |  1 +
 .../devicetree/bindings/sound/samsung,odroid.yaml      |  2 ++
 .../devicetree/bindings/soundwire/qcom,soundwire.yaml  |  1 +
 .../bindings/spi/allwinner,sun4i-a10-spi.yaml          |  1 +
 .../bindings/spi/allwinner,sun6i-a31-spi.yaml          |  1 +
 .../devicetree/bindings/spi/spi-controller.yaml        |  1 +
 .../sram/allwinner,sun4i-a10-system-control.yaml       | 10 +++++-----
 Documentation/devicetree/bindings/sram/qcom,ocmem.yaml |  1 +
 .../devicetree/bindings/thermal/thermal-zones.yaml     |  1 +
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml   |  1 +
 36 files changed, 65 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml +1 -0
index eec190a96225..09c319f803ba 100644
@@ -144,6 +144,7 @@ patternProperties:
       it is stricter and always has two compatibles.
     type: object
     $ref: '/schemas/simple-bus.yaml'
+    unevaluatedProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +3 -2
index b369b374fc4a..39e3c248f5b7 100644
@@ -30,6 +30,7 @@ properties:
 
   clocks:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -47,6 +48,7 @@ properties:
 
   reset:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -63,6 +65,7 @@ properties:
 
   pwm:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -76,8 +79,6 @@ properties:
       - compatible
       - "#pwm-cells"
 
-    additionalProperties: false
-
 required:
   - compatible
   - mboxes
Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml +4 -0
index 4a00593b9f7f..89191cfdf619 100644
@@ -234,6 +234,7 @@ properties:
     patternProperties:
       "^[a-z0-9]+$":
         type: object
+        additionalProperties: false
 
         properties:
           clocks:
@@ -252,6 +253,9 @@ properties:
               for controlling a power-gate.
               See ../reset/reset.txt for more details.
 
+          power-domains:
+            maxItems: 1
+
           '#power-domain-cells':
             const: 0
             description: Must be 0.
Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml +1 -0
index 85c4a979aec4..9845a187bdf6 100644
@@ -46,6 +46,7 @@ patternProperties:
   # All other properties should be child nodes with unit-address and 'reg'
   "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/bus/allwinner,sun8i-a23-rsb.yaml +1 -0
index bee5f53f837f..24c939f59091 100644
@@ -45,6 +45,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-fA-F]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.yaml +6 -0
index 5fb4e7bfa4da..8073988937a8 100644
@@ -56,8 +56,11 @@ patternProperties:
     description: Devices attached to chip selects are represented as
       subnodes.
     type: object
+    additionalProperties: true
 
     properties:
+      reg: true
+
       intel,ixp4xx-eb-t1:
         description: Address timing, extend address phase with n cycles.
         $ref: /schemas/types.yaml#/definitions/uint32
@@ -120,6 +123,9 @@ patternProperties:
         $ref: /schemas/types.yaml#/definitions/uint32
         enum: [0, 1]
 
+    required:
+      - reg
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/bus/palmbus.yaml +1 -0
index 30fa6526cfc2..c36c1e92a573 100644
@@ -36,6 +36,7 @@ patternProperties:
   # All other properties should be child nodes with unit-address and 'reg'
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml +5 -0
index ba0460268731..14380596027b 100644
@@ -86,18 +86,21 @@ required:
 patternProperties:
   "^mdp@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,mdp5
 
   "^dsi@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,mdss-dsi-ctrl
 
   "^phy@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
@@ -110,6 +113,7 @@ patternProperties:
 
   "^hdmi-phy@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
@@ -121,6 +125,7 @@ patternProperties:
 
   "^hdmi-tx@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
Documentation/devicetree/bindings/example-schema.yaml +2 -0
index dfcf4c27d44a..f4eec4c42fb3 100644
@@ -176,6 +176,8 @@ properties:
     description: Child nodes are just another property from a json-schema
       perspective.
     type: object  # DT nodes are json objects
+    # Child nodes also need additionalProperties or unevaluatedProperties
+    additionalProperties: false
     properties:
       vendor,a-child-node-property:
         description: Child node properties have all the same schema
Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml +1 -0
index 7f26f6b1eea1..31906c253940 100644
@@ -35,6 +35,7 @@ properties:
 patternProperties:
   "^.*-pins?$":
     $ref: /schemas/pinctrl/pinmux-node.yaml#
+    additionalProperties: false
 
     properties:
       pins:
Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml +1 -0
index 64a8fcb7bc46..14142b59ee9c 100644
@@ -32,6 +32,7 @@ properties:
 patternProperties:
   "^channel@([0-1])$":
     type: object
+    additionalProperties: false
     description: |
       Represents the two supplies to be monitored.
 
Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml +2 -0
index 9f7d3e11aacb..2e72d0acc13d 100644
@@ -133,12 +133,14 @@ properties:
 
   ppi-partitions:
     type: object
+    additionalProperties: false
     description:
       PPI affinity can be expressed as a single "ppi-partitions" node,
       containing a set of sub-nodes.
     patternProperties:
       "^interrupt-partition-[0-9]+$":
         type: object
+        additionalProperties: false
         properties:
           affinity:
             $ref: /schemas/types.yaml#/definitions/phandle-array
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml +1 -0
index 2193141dd7fd..d546b9e0744d 100644
@@ -72,6 +72,7 @@ patternProperties:
   '^mailbox@[0-9a-f]+$':
     description: Internal ipi mailbox node
     type: object  # DT nodes are json objects
+    additionalProperties: false
     properties:
       xlnx,ipi-id:
         description:
Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml +7 -0
index 90315e217003..13681748559e 100644
@@ -141,6 +141,7 @@ properties:
     patternProperties:
       "^i2c@[0-3]$":
         type: object
+        additionalProperties: false
         description: |
           Child node of the i2c bus multiplexer which represents a GMSL link.
           Each serializer device on the GMSL link remote end is represented with
@@ -152,6 +153,12 @@ properties:
             description: The index of the GMSL channel.
             maxItems: 1
 
+          '#address-cells':
+            const: 1
+
+          '#size-cells':
+            const: 0
+
         patternProperties:
           "^camera@[a-f0-9]+$":
             type: object
Documentation/devicetree/bindings/memory-controllers/arm,pl35x-smc.yaml +1 -0
index bd23257fe021..6d3962a17e49 100644
@@ -73,6 +73,7 @@ properties:
 patternProperties:
   "@[0-7],[a-f0-9]+$":
     type: object
+    additionalProperties: true
     description: |
       The child device node represents the controller connected to the SMC
       bus. The controller can be a NAND controller or a pair of any memory
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml +1 -0
index c6e44f47ce7c..10a2d97e5f8b 100644
@@ -38,6 +38,7 @@ properties:
 patternProperties:
   "^.*@[0-3],[a-f0-9]+$":
     type: object
+    additionalProperties: true
     description:
       The actual device nodes should be added as subnodes to the SROMc node.
       These subnodes, in addition to regular device specification, should
Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml +1 -0
index 9163c3f12a85..f5f03bf36413 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "^emc-timings-[0-9]+$":
     type: object
+    additionalProperties: false
     properties:
       nvidia,ram-code:
         $ref: /schemas/types.yaml#/definitions/uint32
Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml +1 -0
index e76ba767dfd2..14f1833d37c9 100644
@@ -47,6 +47,7 @@ properties:
 
 patternProperties:
   "^.*@[0-4],[a-f0-9]+$":
+    additionalProperties: true
     type: object
     $ref: mc-peripheral-props.yaml#
 
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml +2 -0
index 5644882db2e8..c9574b243046 100644
@@ -35,6 +35,7 @@ properties:
 
   adc:
     type: object
+    additionalProperties: false
     description: |
       Provides 9 channels for system monitoring, including VBUSDIV5 (lower
       accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower
@@ -73,6 +74,7 @@ properties:
 
   regulators:
     type: object
+    additionalProperties: false
     description: |
       List all supported regulators, which support the control for DisplayBias
       voltages and one general purpose LDO which commonly used to drive the
Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml +1 -0
index 987b287f3bff..9fce8cd7b0b6 100644
@@ -42,6 +42,7 @@ patternProperties:
   "^sdhci@[0-9a-f]+$":
     type: object
     $ref: mmc-controller.yaml
+    unevaluatedProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/mtd/mtd.yaml +1 -0
index 78da129e9985..da3d488c335f 100644
@@ -44,6 +44,7 @@ patternProperties:
 
   "^otp(-[0-9]+)?$":
     $ref: ../nvmem/nvmem.yaml#
+    unevaluatedProperties: false
 
     description: |
       An OTP memory region. Some flashes provide a one-time-programmable
Documentation/devicetree/bindings/power/supply/ti,lp8727.yaml +1 -0
index ce6fbdba8f6b..0542d4126cf5 100644
@@ -28,6 +28,7 @@ properties:
 patternProperties:
   '^(ac|usb)$':
     type: object
+    additionalProperties: false
     description: USB/AC charging parameters
     properties:
       charger-type:
Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml +2 -1
index c1cc69b51981..9ce8d8b427fa 100644
@@ -38,8 +38,9 @@ properties:
 
 patternProperties:
   "power-domain@[0-9a-f]+$":
-
     type: object
+    additionalProperties: false
+
     properties:
       compatible:
         items:
Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml +1 -0
index 33748a061898..a46411149571 100644
@@ -54,6 +54,7 @@ patternProperties:
   "^timer@[0-2]$":
     description: The timer block channels that are used as timers or counters.
     type: object
+    additionalProperties: false
     properties:
       compatible:
         items:
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +1 -0
index 847873289f25..7ab96baf2064 100644
@@ -130,6 +130,7 @@ patternProperties:
       PRU-ICSS configuration space. CFG sub-module represented as a SysCon.
 
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/sound/marvell,mmp-sspa.yaml +1 -0
index f302fe89a253..4193d17d1c62 100644
@@ -60,6 +60,7 @@ properties:
     properties:
       endpoint:
         type: object
+        additionalProperties: true
 
         properties:
           dai-format:
Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml +1 -0
index 184e8ccbdd13..19c4deae74b8 100644
@@ -132,6 +132,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     description: |
       WCD934x subnode for each slave devices. Bindings of each subnodes
       depends on the specific driver providing the functionality and
Documentation/devicetree/bindings/sound/samsung,odroid.yaml +2 -0
index 7b4e08ddef6a..51a101558c7b 100644
@@ -35,12 +35,14 @@ properties:
 
   cpu:
     type: object
+    additionalProperties: false
     properties:
       sound-dai:
         description: phandles to the I2S controllers
 
   codec:
     type: object
+    additionalProperties: false
     properties:
       sound-dai:
         items:
Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml +1 -0
index bcbfa71536cd..a191a966cf64 100644
@@ -200,6 +200,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f],[0-9a-f]$":
     type: object
+    additionalProperties: true
     description:
       Child nodes for a standalone audio codec or speaker amplifier IC.
       It has RX and TX Soundwire secondary devices.
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +1 -0
index f1176a28fd87..c18eafbfde8c 100644
@@ -51,6 +51,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +1 -0
index 58b7056f4a70..e2187d395bd1 100644
@@ -63,6 +63,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/spi-controller.yaml +1 -0
index 5a7c72cadf76..90945f59b7e8 100644
@@ -94,6 +94,7 @@ patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
     $ref: spi-peripheral-props.yaml
+    additionalProperties: true
 
     properties:
       spi-3wire:
Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml +5 -5
index 98a7dc7f467d..a1c96985951f 100644
@@ -57,17 +57,17 @@ properties:
 
 patternProperties:
   "^sram@[a-z0-9]+":
-    type: object
-
-    properties:
-      compatible:
-        const: mmio-sram
+    $ref: /schemas/sram/sram.yaml#
+    unevaluatedProperties: false
 
     patternProperties:
       "^sram-section?@[a-f0-9]+$":
         type: object
+        additionalProperties: false
 
         properties:
+          reg: true
+
           compatible:
             oneOf:
               - const: allwinner,sun4i-a10-sram-a3-a4
Documentation/devicetree/bindings/sram/qcom,ocmem.yaml +1 -0
index 071f2d676196..4bbf6db0b6bd 100644
@@ -61,6 +61,7 @@ additionalProperties: false
 patternProperties:
   "-sram@[0-9a-f]+$":
     type: object
+    additionalProperties: false
     description: A region of reserved memory.
 
     properties:
Documentation/devicetree/bindings/thermal/thermal-zones.yaml +1 -0
index 8581821fa4e1..4f3acdc4dec0 100644
@@ -171,6 +171,7 @@ patternProperties:
 
       cooling-maps:
         type: object
+        additionalProperties: false
         description:
           This node describes the action to be taken when a thermal zone
           crosses one of the temperature thresholds described in the trips
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +1 -0
index a3f8a3f49852..3cdd40f8acc0 100644
@@ -118,6 +118,7 @@ properties:
 patternProperties:
   "^usb@[0-9a-f]+$":
     $ref: snps,dwc3.yaml#
+    unevaluatedProperties: false
 
     properties:
       wakeup-source: false
Signature · 1 line
2.39.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

Kind regards
Uffe

Quoted 639 lines

---
To: Krzysztof Kozlowski <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Bartosz Golaszewski <[email protected]>
To: Jean Delvare <[email protected]>
To: Guenter Roeck <[email protected]>
To: Thomas Gleixner <[email protected]>
To: Marc Zyngier <[email protected]>
To: Jassi Brar <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Lee Jones <[email protected]>
To: Ulf Hansson <[email protected]>
To: Richard Weinberger <[email protected]>
To: Vignesh Raghavendra <[email protected]>
To: Sebastian Reichel <[email protected]>
To: Mark Brown <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Daniel Lezcano <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 .../devicetree/bindings/arm/arm,vexpress-juno.yaml     |  1 +
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml |  5 +++--
 .../bindings/arm/tegra/nvidia,tegra20-pmc.yaml         |  4 ++++
 .../bindings/bus/allwinner,sun50i-a64-de2.yaml         |  1 +
 .../bindings/bus/allwinner,sun8i-a23-rsb.yaml          |  1 +
 .../bus/intel,ixp4xx-expansion-bus-controller.yaml     |  6 ++++++
 Documentation/devicetree/bindings/bus/palmbus.yaml     |  1 +
 .../devicetree/bindings/display/msm/qcom,mdss.yaml     |  5 +++++
 Documentation/devicetree/bindings/example-schema.yaml  |  2 ++
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +
 .../devicetree/bindings/hwmon/adi,ltc2992.yaml         |  1 +
 .../bindings/interrupt-controller/arm,gic-v3.yaml      |  2 ++
 .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml      |  1 +
 .../devicetree/bindings/media/i2c/maxim,max9286.yaml   |  7 +++++++
 .../bindings/memory-controllers/arm,pl35x-smc.yaml     |  1 +
 .../bindings/memory-controllers/exynos-srom.yaml       |  1 +
 .../memory-controllers/nvidia,tegra124-emc.yaml        |  1 +
 .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml |  1 +
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml       |  2 ++
 .../devicetree/bindings/mmc/aspeed,sdhci.yaml          |  1 +
 Documentation/devicetree/bindings/mtd/mtd.yaml         |  1 +
 .../devicetree/bindings/power/supply/ti,lp8727.yaml    |  1 +
 .../devicetree/bindings/soc/imx/fsl,imx93-src.yaml     |  3 ++-
 .../bindings/soc/microchip/atmel,at91rm9200-tcb.yaml   |  1 +
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml |  1 +
 .../devicetree/bindings/sound/marvell,mmp-sspa.yaml    |  1 +
 .../devicetree/bindings/sound/qcom,wcd934x.yaml        |  1 +
 .../devicetree/bindings/sound/samsung,odroid.yaml      |  2 ++
 .../devicetree/bindings/soundwire/qcom,soundwire.yaml  |  1 +
 .../bindings/spi/allwinner,sun4i-a10-spi.yaml          |  1 +
 .../bindings/spi/allwinner,sun6i-a31-spi.yaml          |  1 +
 .../devicetree/bindings/spi/spi-controller.yaml        |  1 +
 .../sram/allwinner,sun4i-a10-system-control.yaml       | 10 +++++-----
 Documentation/devicetree/bindings/sram/qcom,ocmem.yaml |  1 +
 .../devicetree/bindings/thermal/thermal-zones.yaml     |  1 +
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml   |  1 +
 36 files changed, 65 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml +1 -0
index eec190a96225..09c319f803ba 100644
@@ -144,6 +144,7 @@ patternProperties:
       it is stricter and always has two compatibles.
     type: object
     $ref: '/schemas/simple-bus.yaml'
+    unevaluatedProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +3 -2
index b369b374fc4a..39e3c248f5b7 100644
@@ -30,6 +30,7 @@ properties:
 
   clocks:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -47,6 +48,7 @@ properties:
 
   reset:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -63,6 +65,7 @@ properties:
 
   pwm:
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
@@ -76,8 +79,6 @@ properties:
       - compatible
       - "#pwm-cells"
 
-    additionalProperties: false
-
 required:
   - compatible
   - mboxes
Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml +4 -0
index 4a00593b9f7f..89191cfdf619 100644
@@ -234,6 +234,7 @@ properties:
     patternProperties:
       "^[a-z0-9]+$":
         type: object
+        additionalProperties: false
 
         properties:
           clocks:
@@ -252,6 +253,9 @@ properties:
               for controlling a power-gate.
               See ../reset/reset.txt for more details.
 
+          power-domains:
+            maxItems: 1
+
           '#power-domain-cells':
             const: 0
             description: Must be 0.
Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml +1 -0
index 85c4a979aec4..9845a187bdf6 100644
@@ -46,6 +46,7 @@ patternProperties:
   # All other properties should be child nodes with unit-address and 'reg'
   "^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/bus/allwinner,sun8i-a23-rsb.yaml +1 -0
index bee5f53f837f..24c939f59091 100644
@@ -45,6 +45,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-fA-F]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.yaml +6 -0
index 5fb4e7bfa4da..8073988937a8 100644
@@ -56,8 +56,11 @@ patternProperties:
     description: Devices attached to chip selects are represented as
       subnodes.
     type: object
+    additionalProperties: true
 
     properties:
+      reg: true
+
       intel,ixp4xx-eb-t1:
         description: Address timing, extend address phase with n cycles.
         $ref: /schemas/types.yaml#/definitions/uint32
@@ -120,6 +123,9 @@ patternProperties:
         $ref: /schemas/types.yaml#/definitions/uint32
         enum: [0, 1]
 
+    required:
+      - reg
+
 required:
   - compatible
   - reg
Documentation/devicetree/bindings/bus/palmbus.yaml +1 -0
index 30fa6526cfc2..c36c1e92a573 100644
@@ -36,6 +36,7 @@ patternProperties:
   # All other properties should be child nodes with unit-address and 'reg'
   "@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     properties:
       reg:
         maxItems: 1
Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml +5 -0
index ba0460268731..14380596027b 100644
@@ -86,18 +86,21 @@ required:
 patternProperties:
   "^mdp@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,mdp5
 
   "^dsi@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         const: qcom,mdss-dsi-ctrl
 
   "^phy@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
@@ -110,6 +113,7 @@ patternProperties:
 
   "^hdmi-phy@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
@@ -121,6 +125,7 @@ patternProperties:
 
   "^hdmi-tx@[1-9a-f][0-9a-f]*$":
     type: object
+    additionalProperties: true
     properties:
       compatible:
         enum:
Documentation/devicetree/bindings/example-schema.yaml +2 -0
index dfcf4c27d44a..f4eec4c42fb3 100644
@@ -176,6 +176,8 @@ properties:
     description: Child nodes are just another property from a json-schema
       perspective.
     type: object  # DT nodes are json objects
+    # Child nodes also need additionalProperties or unevaluatedProperties
+    additionalProperties: false
     properties:
       vendor,a-child-node-property:
         description: Child node properties have all the same schema
Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml +1 -0
index 7f26f6b1eea1..31906c253940 100644
@@ -35,6 +35,7 @@ properties:
 patternProperties:
   "^.*-pins?$":
     $ref: /schemas/pinctrl/pinmux-node.yaml#
+    additionalProperties: false
 
     properties:
       pins:
Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml +1 -0
index 64a8fcb7bc46..14142b59ee9c 100644
@@ -32,6 +32,7 @@ properties:
 patternProperties:
   "^channel@([0-1])$":
     type: object
+    additionalProperties: false
     description: |
       Represents the two supplies to be monitored.
 
Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml +2 -0
index 9f7d3e11aacb..2e72d0acc13d 100644
@@ -133,12 +133,14 @@ properties:
 
   ppi-partitions:
     type: object
+    additionalProperties: false
     description:
       PPI affinity can be expressed as a single "ppi-partitions" node,
       containing a set of sub-nodes.
     patternProperties:
       "^interrupt-partition-[0-9]+$":
         type: object
+        additionalProperties: false
         properties:
           affinity:
             $ref: /schemas/types.yaml#/definitions/phandle-array
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml +1 -0
index 2193141dd7fd..d546b9e0744d 100644
@@ -72,6 +72,7 @@ patternProperties:
   '^mailbox@[0-9a-f]+$':
     description: Internal ipi mailbox node
     type: object  # DT nodes are json objects
+    additionalProperties: false
     properties:
       xlnx,ipi-id:
         description:
Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml +7 -0
index 90315e217003..13681748559e 100644
@@ -141,6 +141,7 @@ properties:
     patternProperties:
       "^i2c@[0-3]$":
         type: object
+        additionalProperties: false
         description: |
           Child node of the i2c bus multiplexer which represents a GMSL link.
           Each serializer device on the GMSL link remote end is represented with
@@ -152,6 +153,12 @@ properties:
             description: The index of the GMSL channel.
             maxItems: 1
 
+          '#address-cells':
+            const: 1
+
+          '#size-cells':
+            const: 0
+
         patternProperties:
           "^camera@[a-f0-9]+$":
             type: object
Documentation/devicetree/bindings/memory-controllers/arm,pl35x-smc.yaml +1 -0
index bd23257fe021..6d3962a17e49 100644
@@ -73,6 +73,7 @@ properties:
 patternProperties:
   "@[0-7],[a-f0-9]+$":
     type: object
+    additionalProperties: true
     description: |
       The child device node represents the controller connected to the SMC
       bus. The controller can be a NAND controller or a pair of any memory
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml +1 -0
index c6e44f47ce7c..10a2d97e5f8b 100644
@@ -38,6 +38,7 @@ properties:
 patternProperties:
   "^.*@[0-3],[a-f0-9]+$":
     type: object
+    additionalProperties: true
     description:
       The actual device nodes should be added as subnodes to the SROMc node.
       These subnodes, in addition to regular device specification, should
Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml +1 -0
index 9163c3f12a85..f5f03bf36413 100644
@@ -50,6 +50,7 @@ properties:
 patternProperties:
   "^emc-timings-[0-9]+$":
     type: object
+    additionalProperties: false
     properties:
       nvidia,ram-code:
         $ref: /schemas/types.yaml#/definitions/uint32
Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml +1 -0
index e76ba767dfd2..14f1833d37c9 100644
@@ -47,6 +47,7 @@ properties:
 
 patternProperties:
   "^.*@[0-4],[a-f0-9]+$":
+    additionalProperties: true
     type: object
     $ref: mc-peripheral-props.yaml#
 
Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml +2 -0
index 5644882db2e8..c9574b243046 100644
@@ -35,6 +35,7 @@ properties:
 
   adc:
     type: object
+    additionalProperties: false
     description: |
       Provides 9 channels for system monitoring, including VBUSDIV5 (lower
       accuracy, higher measure range), VBUSDIV2 (higher accuracy, lower
@@ -73,6 +74,7 @@ properties:
 
   regulators:
     type: object
+    additionalProperties: false
     description: |
       List all supported regulators, which support the control for DisplayBias
       voltages and one general purpose LDO which commonly used to drive the
Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml +1 -0
index 987b287f3bff..9fce8cd7b0b6 100644
@@ -42,6 +42,7 @@ patternProperties:
   "^sdhci@[0-9a-f]+$":
     type: object
     $ref: mmc-controller.yaml
+    unevaluatedProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/mtd/mtd.yaml +1 -0
index 78da129e9985..da3d488c335f 100644
@@ -44,6 +44,7 @@ patternProperties:
 
   "^otp(-[0-9]+)?$":
     $ref: ../nvmem/nvmem.yaml#
+    unevaluatedProperties: false
 
     description: |
       An OTP memory region. Some flashes provide a one-time-programmable
Documentation/devicetree/bindings/power/supply/ti,lp8727.yaml +1 -0
index ce6fbdba8f6b..0542d4126cf5 100644
@@ -28,6 +28,7 @@ properties:
 patternProperties:
   '^(ac|usb)$':
     type: object
+    additionalProperties: false
     description: USB/AC charging parameters
     properties:
       charger-type:
Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml +2 -1
index c1cc69b51981..9ce8d8b427fa 100644
@@ -38,8 +38,9 @@ properties:
 
 patternProperties:
   "power-domain@[0-9a-f]+$":
-
     type: object
+    additionalProperties: false
+
     properties:
       compatible:
         items:
Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml +1 -0
index 33748a061898..a46411149571 100644
@@ -54,6 +54,7 @@ patternProperties:
   "^timer@[0-2]$":
     description: The timer block channels that are used as timers or counters.
     type: object
+    additionalProperties: false
     properties:
       compatible:
         items:
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +1 -0
index 847873289f25..7ab96baf2064 100644
@@ -130,6 +130,7 @@ patternProperties:
       PRU-ICSS configuration space. CFG sub-module represented as a SysCon.
 
     type: object
+    additionalProperties: false
 
     properties:
       compatible:
Documentation/devicetree/bindings/sound/marvell,mmp-sspa.yaml +1 -0
index f302fe89a253..4193d17d1c62 100644
@@ -60,6 +60,7 @@ properties:
     properties:
       endpoint:
         type: object
+        additionalProperties: true
 
         properties:
           dai-format:
Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml +1 -0
index 184e8ccbdd13..19c4deae74b8 100644
@@ -132,6 +132,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: true
     description: |
       WCD934x subnode for each slave devices. Bindings of each subnodes
       depends on the specific driver providing the functionality and
Documentation/devicetree/bindings/sound/samsung,odroid.yaml +2 -0
index 7b4e08ddef6a..51a101558c7b 100644
@@ -35,12 +35,14 @@ properties:
 
   cpu:
     type: object
+    additionalProperties: false
     properties:
       sound-dai:
         description: phandles to the I2S controllers
 
   codec:
     type: object
+    additionalProperties: false
     properties:
       sound-dai:
         items:
Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml +1 -0
index bcbfa71536cd..a191a966cf64 100644
@@ -200,6 +200,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f],[0-9a-f]$":
     type: object
+    additionalProperties: true
     description:
       Child nodes for a standalone audio codec or speaker amplifier IC.
       It has RX and TX Soundwire secondary devices.
Documentation/devicetree/bindings/spi/allwinner,sun4i-a10-spi.yaml +1 -0
index f1176a28fd87..c18eafbfde8c 100644
@@ -51,6 +51,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml +1 -0
index 58b7056f4a70..e2187d395bd1 100644
@@ -63,6 +63,7 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+":
     type: object
+    additionalProperties: true
     properties:
       reg:
         items:
Documentation/devicetree/bindings/spi/spi-controller.yaml +1 -0
index 5a7c72cadf76..90945f59b7e8 100644
@@ -94,6 +94,7 @@ patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
     $ref: spi-peripheral-props.yaml
+    additionalProperties: true
 
     properties:
       spi-3wire:
Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml +5 -5
index 98a7dc7f467d..a1c96985951f 100644
@@ -57,17 +57,17 @@ properties:
 
 patternProperties:
   "^sram@[a-z0-9]+":
-    type: object
-
-    properties:
-      compatible:
-        const: mmio-sram
+    $ref: /schemas/sram/sram.yaml#
+    unevaluatedProperties: false
 
     patternProperties:
       "^sram-section?@[a-f0-9]+$":
         type: object
+        additionalProperties: false
 
         properties:
+          reg: true
+
           compatible:
             oneOf:
               - const: allwinner,sun4i-a10-sram-a3-a4
Documentation/devicetree/bindings/sram/qcom,ocmem.yaml +1 -0
index 071f2d676196..4bbf6db0b6bd 100644
@@ -61,6 +61,7 @@ additionalProperties: false
 patternProperties:
   "-sram@[0-9a-f]+$":
     type: object
+    additionalProperties: false
     description: A region of reserved memory.
 
     properties:
Documentation/devicetree/bindings/thermal/thermal-zones.yaml +1 -0
index 8581821fa4e1..4f3acdc4dec0 100644
@@ -171,6 +171,7 @@ patternProperties:
 
       cooling-maps:
         type: object
+        additionalProperties: false
         description:
           This node describes the action to be taken when a thermal zone
           crosses one of the temperature thresholds described in the trips
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +1 -1
index a3f8a3f49852..3cdd40f8acc0 100644
@@ -118,6 +118,7 @@ properties:
 patternProperties:
   "^usb@[0-9a-f]+$":
     $ref: snps,dwc3.yaml#
+    unevaluatedProperties: false
 
     properties:
       wakeup-source: false
--

2.39.0

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 7 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

Acked-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

[...]

Quoted 1 line
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +

[...]

Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml properties: · line 41

Quoted 12 lines
Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml +1 -0
index 7f26f6b1eea1..31906c253940 100644
@@ -35,6 +35,7 @@ properties:
 patternProperties:
   "^.*-pins?$":
     $ref: /schemas/pinctrl/pinmux-node.yaml#
+    additionalProperties: false
 
     properties:
       pins:

[...]

maintainer Acked-by on v1 1/1
#6 lore raw
In reply to Rob Herring
Quoted 33 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---
To: Krzysztof Kozlowski <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Bartosz Golaszewski <[email protected]>
To: Jean Delvare <[email protected]>
To: Guenter Roeck <[email protected]>
To: Thomas Gleixner <[email protected]>
To: Marc Zyngier <[email protected]>
To: Jassi Brar <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Lee Jones <[email protected]>
To: Ulf Hansson <[email protected]>
To: Richard Weinberger <[email protected]>
To: Vignesh Raghavendra <[email protected]>
To: Sebastian Reichel <[email protected]>
To: Mark Brown <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Daniel Lezcano <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Quoted 8 lines

Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

maintainer
#7 lore raw
In reply to Rob Herring
Quoted 71 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---
To: Krzysztof Kozlowski <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Bartosz Golaszewski <[email protected]>
To: Jean Delvare <[email protected]>
To: Guenter Roeck <[email protected]>
To: Thomas Gleixner <[email protected]>
To: Marc Zyngier <[email protected]>
To: Jassi Brar <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>
To: Lee Jones <[email protected]>
To: Ulf Hansson <[email protected]>
To: Richard Weinberger <[email protected]>
To: Vignesh Raghavendra <[email protected]>
To: Sebastian Reichel <[email protected]>
To: Mark Brown <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Daniel Lezcano <[email protected]>
To: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 .../devicetree/bindings/arm/arm,vexpress-juno.yaml     |  1 +
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml |  5 +++--
 .../bindings/arm/tegra/nvidia,tegra20-pmc.yaml         |  4 ++++
 .../bindings/bus/allwinner,sun50i-a64-de2.yaml         |  1 +
 .../bindings/bus/allwinner,sun8i-a23-rsb.yaml          |  1 +
 .../bus/intel,ixp4xx-expansion-bus-controller.yaml     |  6 ++++++
 Documentation/devicetree/bindings/bus/palmbus.yaml     |  1 +
 .../devicetree/bindings/display/msm/qcom,mdss.yaml     |  5 +++++
 Documentation/devicetree/bindings/example-schema.yaml  |  2 ++
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +
 .../devicetree/bindings/hwmon/adi,ltc2992.yaml         |  1 +
 .../bindings/interrupt-controller/arm,gic-v3.yaml      |  2 ++
 .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml      |  1 +
 .../devicetree/bindings/media/i2c/maxim,max9286.yaml   |  7 +++++++
 .../bindings/memory-controllers/arm,pl35x-smc.yaml     |  1 +
 .../bindings/memory-controllers/exynos-srom.yaml       |  1 +
 .../memory-controllers/nvidia,tegra124-emc.yaml        |  1 +
 .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml |  1 +
 .../devicetree/bindings/mfd/mediatek,mt6370.yaml       |  2 ++
 .../devicetree/bindings/mmc/aspeed,sdhci.yaml          |  1 +
 Documentation/devicetree/bindings/mtd/mtd.yaml         |  1 +
 .../devicetree/bindings/power/supply/ti,lp8727.yaml    |  1 +
 .../devicetree/bindings/soc/imx/fsl,imx93-src.yaml     |  3 ++-
 .../bindings/soc/microchip/atmel,at91rm9200-tcb.yaml   |  1 +
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml |  1 +
 .../devicetree/bindings/sound/marvell,mmp-sspa.yaml    |  1 +
 .../devicetree/bindings/sound/qcom,wcd934x.yaml        |  1 +
 .../devicetree/bindings/sound/samsung,odroid.yaml      |  2 ++
 .../devicetree/bindings/soundwire/qcom,soundwire.yaml  |  1 +
Quoted 8 lines
 .../bindings/spi/allwinner,sun4i-a10-spi.yaml          |  1 +
 .../bindings/spi/allwinner,sun6i-a31-spi.yaml          |  1 +
 .../devicetree/bindings/spi/spi-controller.yaml        |  1 +
 .../sram/allwinner,sun4i-a10-system-control.yaml       | 10 +++++-----
 Documentation/devicetree/bindings/sram/qcom,ocmem.yaml |  1 +
 .../devicetree/bindings/thermal/thermal-zones.yaml     |  1 +
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml   |  1 +
 36 files changed, 65 insertions(+), 8 deletions(-)

Is this the same as the patch I just reviewed?

Signature · 1 line
Lee Jones [李琼斯]
maintainer Acked-by on v1 1/1
#8 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

For the mailbox change,

Acked-by Jassi Brar
#9 lore raw

You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad
________________________________
From: linux-mtd <[email protected]> on behalf of Jassi Brar <[email protected]>
Sent: Wednesday, January 25, 2023 11:26 AM
To: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Bartosz Golaszewski <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

For the mailbox change,

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Acked-by Jassi Brar
#10 lore raw

Lonely nasty ass dumbass
________________________________
From: Vanessa Page <[email protected]>
Sent: Wednesday, January 25, 2023 11:59 AM
To: Jassi Brar <[email protected]>; Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Bartosz Golaszewski <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad
________________________________
From: linux-mtd <[email protected]> on behalf of Jassi Brar <[email protected]>
Sent: Wednesday, January 25, 2023 11:26 AM
To: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Bartosz Golaszewski <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

For the mailbox change,

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Acked-by Bartosz Golaszewski
#4 lore raw
In reply to Bartosz Golaszewski

You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad

________________________________
From: linux-mtd <[email protected]> on behalf of Bartosz Golaszewski <[email protected]>
Sent: Wednesday, January 25, 2023 8:01 AM
To: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Jassi Brar <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

[...]

Quoted 1 line
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +

[...]

Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml properties: · line 41

Quoted 12 lines
Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml +1 -0
index 7f26f6b1eea1..31906c253940 100644
@@ -35,6 +35,7 @@ properties:
 patternProperties:
   "^.*-pins?$":
     $ref: /schemas/pinctrl/pinmux-node.yaml#
+    additionalProperties: false
 
     properties:
       pins:

[...]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Acked-by Bartosz Golaszewski
#5 lore raw

Nobody has to work with your delusional ass. Oh your a .ORG ??? In America??? I'm supposed to TRUST a mentally insane institutionalized country government system that RAPED slaves and lets men RAPE women and make them prove it???? A country who's own president raped slaves. That nasty genuwine looking mother fucker sitting on Oprah next to that white DUMB as bitch. You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad

News flash not everyone in Africa were slaves or barbaric animals or walking around naked like the US gov tought to white lids when black kids did it have education rights. Sat there nasty tea drinking frail pale ugly asses up there and lied about ALL African people. You think ima sit here like a dumb bitch and let YOU harass me???!!!!! You got it coming to you dipshit. You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad

Keep going

________________________________
From: Vanessa Page <[email protected]>
Sent: Wednesday, January 25, 2023 12:00 PM
To: Bartosz Golaszewski <[email protected]>; Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Jassi Brar <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

You are a disgusting disgraceful piece of shit as human being you deserve to eat yeah and literal human feces until you DIE motherfucker. You dumb fuck. Have nothing better to do. KEEP talking motherfucker KEEP FUCKING talking. YOUR DELUSIONAL. It’s sad

________________________________
From: linux-mtd <[email protected]> on behalf of Bartosz Golaszewski <[email protected]>
Sent: Wednesday, January 25, 2023 8:01 AM
To: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Thomas Gleixner <[email protected]>; Marc Zyngier <[email protected]>; Jassi Brar <[email protected]>; Mauro Carvalho Chehab <[email protected]>; Lee Jones <[email protected]>; Ulf Hansson <[email protected]>; Richard Weinberger <[email protected]>; Vignesh Raghavendra <[email protected]>; Sebastian Reichel <[email protected]>; Mark Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Daniel Lezcano <[email protected]>; Greg Kroah-Hartman <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

Quoted 11 lines · Rob Herring

Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present.

Add unevaluatedProperties or additionalProperties as appropriate, and then add any missing properties flagged by the addition.

---

[...]

Quoted 1 line
 .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml |  1 +

[...]

Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml properties: · line 41

Quoted 12 lines
Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml +1 -0
index 7f26f6b1eea1..31906c253940 100644
@@ -35,6 +35,7 @@ properties:
 patternProperties:
   "^.*-pins?$":
     $ref: /schemas/pinctrl/pinmux-node.yaml#
+    additionalProperties: false
 
     properties:
       pins:

[...]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/